Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Dropdown): rename combobox to root in dropdownSearchInputStyles #816

Merged
merged 9 commits into from
Feb 4, 2019
Merged

fix(Dropdown): rename combobox to root in dropdownSearchInputStyles #816

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
925632f
fix(Dropdown): add `root` to `dropdownSearchInputStyles`
layershifter Jan 31, 2019
c674b4f
add changelog entry
layershifter Jan 31, 2019
00ec71b
Merge branches 'fix/dropdown-search-inpur' and 'master' of https://gi…
layershifter Feb 1, 2019
df5bff2
Update CHANGELOG.md
layershifter Feb 4, 2019
a89d3b8
move `combobox` to `root`
layershifter Feb 4, 2019
76c996b
Merge branch 'fix/dropdown-search-inpur' of https://github.com/stardu…
layershifter Feb 4, 2019
13113e9
update changelog entry
layershifter Feb 4, 2019
3352b86
Merge branch 'master' into fix/dropdown-search-inpur
layershifter Feb 4, 2019
3ff1a04
update entry position
layershifter Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Features
- Accessibility for menu divider @jurokapsiar ([#822](https://github.com/stardust-ui/react/pull/822))

### BREAKING CHANGES
- Rename `combobox` to `root` in `dropdownSearchInputStyles` @layershifter ([#816](https://github.com/stardust-ui/react/pull/816))

<!--------------------------------[ v0.19.2 ]------------------------------- -->
## [v0.19.2](https://github.com/stardust-ui/react/tree/v0.19.2) (2019-02-01)
[Compare changes](https://github.com/stardust-ui/react/compare/v0.19.1...v0.19.2)
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Dropdown/DropdownSearchInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class DropdownSearchInput extends UIComponent<ReactProps<DropdownSearchInputProp
onFocus={this.handleFocus}
onKeyUp={this.handleKeyUp}
wrapper={{
styles: styles.combobox,
styles: styles.root,
...accessibilityComboboxProps,
}}
input={{
Expand Down
10 changes: 5 additions & 5 deletions packages/react/src/themes/teams/components/Dropdown/dropdownSearchInputStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ const dropdownSearchInputStyles: ComponentSlotStylesInput<
DropdownSearchInputProps,
DropdownVariables
> = {
root: ({ variables: v }): ICSSInJSStyle => ({
flexBasis: v.comboboxFlexBasis,
flexGrow: 1,
}),

input: ({ variables: v }): ICSSInJSStyle => ({
width: '100%',
backgroundColor: v.backgroundColor,
Expand All @@ -14,11 +19,6 @@ const dropdownSearchInputStyles: ComponentSlotStylesInput<
borderBottomColor: 'transparent',
},
}),

combobox: ({ variables: v }): ICSSInJSStyle => ({
flexBasis: v.comboboxFlexBasis,
flexGrow: 1,
}),
}

export default dropdownSearchInputStyles