-
Notifications
You must be signed in to change notification settings - Fork 53
feat(ChatMessage): add hasMention and isImportant variables in Teams theme #841
Conversation
props: p, | ||
variables: v, | ||
theme: { | ||
siteVariables: { orange04, red }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to chatMessageVariables
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will add hasMentionColor
and isImportantColor
variables there.
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 69
=======================================
Hits 681 681
Misses 47 47 Continue to review full report at Codecov.
|
@@ -17,7 +17,6 @@ const items = [ | |||
mine | |||
badge={{ | |||
icon: 'exclamation', | |||
color: 'red', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
-renamed mentionColor and importantColor to hasMentionColor and isImportantColor
This PR adds
hasMention
,isImportant
,hasMentionColor
andisImportantColor
variables in theChatMessage
for Teams theme. These variables are controlling the color of the badge, as well as are adding the left border on the messages.Prototype:
API (Teams theme):
Code: