feat(react-menu, react-positioning): update maxSize to prevent double scrollbar for Menu in small viewport #28622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
YuanboXue-Amber
changed the title
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 600 | 584 | 5000 | |
| Button | mount | 304 | 299 | 5000 | |
| Field | mount | 1063 | 1045 | 5000 | |
| FluentProvider | mount | 630 | 641 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 62 | 61 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 71 | 10 | |
| InfoButton | mount | 11 | 13 | 5000 | |
| MakeStyles | mount | 859 | 848 | 50000 | |
| Persona | mount | 1644 | 1608 | 5000 | |
| SpinButton | mount | 1337 | 1295 | 5000 |
fabricteam
reviewed
Jul 24, 2023
apps/vr-tests-react-components/src/stories/Menu/ScrollableMenuSmallViewport.stories.tsx
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3789163:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e7e522f452c4090c7f4426082efac571e8141a8e (build) |
ling1726
reviewed
Jul 25, 2023
packages/react-components/react-menu/src/components/MenuItem/useMenuItemStyles.styles.ts
Show resolved
Hide resolved
|
/azp run |
|
No commit pushedDate could be found for PR 28622 in repo microsoft/fluentui |
ling1726
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1.a in #28623.
Previous Behavior
A menu in small viewport needs
autoSizeto become scrollable. But if the menu has scrollable menu group inside, it can show double scrollbar:https://codesandbox.io/s/blue-framework-mstvsn?file=/example.tsx
The expected behavior is to shrink the scrollable menu group to fit the entire menu in the viewport.
But this is hard to achieve from user side: the MenuPopover has maxHeight added by autoSize. But MenuList can still overflow MenuPopover even when it has style
height: 100%. This is because height percentage is based on theheightvalue of the parent element, but the parent MenuPopover has onlymaxHeight.New Behavior
The changes:
autoSizemodifier, addheight/widthwhen overflow happens. SetoverflowX/overflowYtoautoonly when overflow happens.height: 100%on MenuList when it is inside Menu context.