Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Runner Performance Improvements #1289

Closed
wants to merge 1 commit into from
Closed

Test Runner Performance Improvements #1289

wants to merge 1 commit into from

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Sep 19, 2016

Work-in-progess PR for issues #518 and #1157

Bug
Fix

TODO

Testing

TODO

@msftclas
Copy link

Hi @ozyx, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@ozyx, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mjbvz
Copy link
Contributor

mjbvz commented Sep 20, 2016

Glad to see that you are starting to look into this.

Please let me know what sort of feedback would be helpful while getting started here and how you'd like to work on this feature. I suggest that we either create a test-adapter branch on the NTVS repo and merge your incremental work into that through PRs, or that you create a branch on your fork and submit PRs against that with a big rollup PR against NTVS once the feature is complete. Whatever you feel most comfortable with.

Really looking forward to seeing this implemented. As always, please let me know if you are blocked or have any questions.

@ozyx
Copy link
Contributor Author

ozyx commented Sep 21, 2016

Oh okay, I'll submit PRs against the branch on my fork.
I'm going to really be digging into this starting this weekend/next week-- and I will definitely have questions for you. 😄

Thanks as always for being so helpful!

Closing this PR then.

@ozyx ozyx closed this Sep 21, 2016
@ozyx
Copy link
Contributor Author

ozyx commented Sep 29, 2016

@mjbvz
Hi,
Just in need of some quick clarification-- I've created a branch on my fork. For submitting a PR against that branch, does it matter which branch on my fork I merge from?

Meaning if I have myfork/test-adapter could I work on myfork/master and submit a PR from myfork/master into myfork/test-adapter branch?
I might be overthinking this.

I have the first set of changes and I'd just like to get them to you guys for review ASAP so I can make sure I'm on the right path.

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants