Allow running .npm commands in Repl Window from any proj types. #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only support running `.npm` commands in node projects for the Repl window. This change allows us to run repl window commands in other project types as well. Since these projects may not have a `package.json` file for npm to use, also added a command to create it.
| @@ -137,7 +111,20 @@ class NpmReplCommand : IReplCommand { | |||
| } | |||
|
|
|||
| var npmReplRedirector = new NpmReplRedirector(window); | |||
|
|
|||
|
|
|||
| if (!isGlobalCommand && !File.Exists(Path.Combine(projectDirectoryPath, "package.json"))) { | |||
There was a problem hiding this comment.
On second thought, I think I'll revert this part of the change. We could try checking and only doing this for npm commands that actually need the package.json, but i think it is better to let the user handle this themselves using npm init.
| @@ -59,7 +59,7 @@ class NpmReplCommand : IReplCommand { | |||
| npmArguments = string.Format(" {0} ", npmArguments); | |||
|
|
|||
| var solution = Package.GetGlobalService(typeof(SVsSolution)) as IVsSolution; | |||
| IEnumerable<IVsProject> loadedProjects = solution.EnumerateLoadedProjects(onlyNodeProjects: true); | |||
| var loadedProjects = solution.EnumerateLoadedProjects(onlyNodeProjects: false); | |||
There was a problem hiding this comment.
try to avoid var unless it's clear what the return type is.
|
added comments. lmk if you have any Qs! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect
We currently only support running
.npmcommands in node projects for the Repl window. #480Fix
This change allows us to run repl window commands in other project types as well, including having a mix of node and other projects in a single solution. This change does not fix the case where you have multiple Node projects in a single solution.
Since these projects may not have a
package.jsonfile for npm to use, also added a command to create it.closes #156, closes #480