-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 IntelliSense UX improvements #981
Conversation
get { | ||
int max; | ||
// The Max Value is described by 'Max' instead of 'Int32.MaxValue' | ||
if (_analysisLogMax.Text == "Max") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
[nit] Also, extract Max
to a constant if it is going to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, see this was moved from other file. Fine leaving it as is.
Where any considerations made for typings acquisition being disabled in VS15? I'm fine merging this in before the VS15 experience is perfect since we don't have a release of that scheduled soon, but we should track this as a future work item. Also, should |
} | ||
return _instance; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Prefer Lazy
to encapsule this pattern.
The change looks great overall and should help users a lot. I added a few nit comments and had a few questions/notes, but there were no major problems in the code. Let's just make sure we are on the same page regarding the VS15 and open any new work items for that before checking this in. We can create another WI for updating the documentation too, since that step shouldn't block this check in but must be done before the 1.2 release. Also, if you are still looking into synchronizing the TS and Node formatting, please do that in another PR so we can keep this one more focused. |
After auto-dts acquisition, the following InfoBar will appear in solution explorer to help educate the user and increase discoverability of the feature.

Clicking on the "typings folder" link will open a web page that includes more information about what's going on under the covers.
Clicking on the "Customize..." button will open the relevant options page, which has been reconstructed to be conditional upon the selected IntelliSense mode. ES6 will use the new Salsa language service, and ES5 will use the old Node.js static analysis engine.
ES6 Mode

ES5 Mode

Additional Considerations
What's missing?