Synchronize Node.js <-> TS settings #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to Salsa. In particular this change: * on startup, populate Node.js options with TS -> Node.js editor settings (general, scrollbars, and tabs) * on Node.js editor settings changed, populate TS options * use TS properties as backing for Node.js formatting settings limitations: * On TS options changed, will not sync back to Node.js * On TS + Node.js options changed, will use Node.js options
| _preferences.fAutoListParams = langPrefs[0].fAutoListParams; | ||
| _preferences.fHideAdvancedAutoListMembers = langPrefs[0].fHideAdvancedAutoListMembers; | ||
| public int OnUserPreferencesChanged4(VIEWPREFERENCES3[] pViewPrefs, LANGPREFERENCES3[] pLangPrefs, FONTCOLORPREFERENCES2[] pColorPrefs) { | ||
| IVsTextManager4 textMgr = (IVsTextManager4)NodejsPackage.Instance.GetService(typeof(SVsTextManager)); |
There was a problem hiding this comment.
We don't null check anywhere, and I wouldn't expect it to ever be null (except maybe inside of some of the mock test cases?)
|
Look good overall. Let's get the CI passing and make sure to test this on a machine without the VS sdk installed and then merge this in for the 1.2 beta. |
mjbvz
added a commit
to mjbvz/nodejstools
that referenced
this pull request
Jun 10, 2016
Issue microsoft#1014 **Bug** Crash in `SmartIndent.cs` in the interactive window. I believe that the root cause is microsoft#995, which changed how we store our settings. **Fix** Switch to using the NodeJs language preferences from typescript instead. This ensures we are using the same logic to get the language settings as we use in other places. closes microsoft#1014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize Node.js <-> TS settings so that Node.js options are applied to Salsa. In particular this change:
limitations: