Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for redacting private/sensitive information #16421

Open
StephenCleary opened this issue Dec 5, 2023 · 2 comments
Open

Support for redacting private/sensitive information #16421

StephenCleary opened this issue Dec 5, 2023 · 2 comments
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@StephenCleary
Copy link

Description of the new feature/enhancement

I'd like the ability to automatically mask sensitive information in terminal windows. Masking application output would be great; masking user input (e.g., passwords on command line) would be nice as well.

This would be useful when screen sharing, demos, and when recording screencasts.

Warp does this.

Proposed technical implementation details (optional)

Terminal needs to know what to mask. At the very least it should have a user-editable series of regexes to detect potentially sensitive information. Even better would be integration with GitHub's existing secret scanning code, masking anything that matches GitHub's token patterns.

Masked information could use a specific Unicode character (or one of a few similar Unicode characters), so it's as obvious as possible that the output was masked.

Ideally, copying a masked value would copy the original plaintext, so copy/paste works the same as it always does, ignoring the masking.

@StephenCleary StephenCleary added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 5, 2023
@237dmitry
Copy link

Like this?

Screenshot 2023-12-06 000442

@zadjii-msft
Copy link
Member

I saw something like this a while back

image

from https://youtu.be/NxsaHxON350?si=af0dLmZVEYsIeJN-&t=503

and I thought it was genuinely super cool. Now admittedly, this is from a project where someone is writing their own shell, so they're able to parse all the output from the client app then change it to colored block-drawing characters before it even hits the Terminal, but I thought it was a super clever idea.

(this of course wouldn't work for a11y at all, but then presumably, you'd disable it if you use a screen reader)

also xlink #5916

@carlos-zamora carlos-zamora added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 6, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Dec 6, 2023
@zadjii-msft zadjii-msft modified the milestones: Backlog, Icebox ❄ Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants