Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast of progress bars when Automatically adjust lightness of indistinguishable text is enabled #18617

Open
chrisrodrigue opened this issue Feb 23, 2025 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@chrisrodrigue
Copy link

chrisrodrigue commented Feb 23, 2025

Windows Terminal version

1.22.10352.0

Windows build number

10.0.22631.4890

Other Software

uv 0.6.2

Steps to reproduce

See astral-sh/uv#11727

I think this is likely an issue with Windows Terminal and not an issue with uv.

Expected Behavior

Image

Actual Behavior

Image

It seems that Automatically adjust lightness of indistinguishable text has the opposite effect on certain progress bars.

@chrisrodrigue chrisrodrigue added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 23, 2025
@lhecker
Copy link
Member

lhecker commented Feb 24, 2025

(Side note: Looking at these screenshots, I'm impressed how well our algorithm predicted the brightened color...)

Do you have a suggestion how we could otherwise handle this? It's difficult for me to think of something that would work in the general case (i.e. even outside of your specific example), as it would require the terminal to be content-aware and recognize that this is a progress bar in the first place. Perhaps I'm overlooking an obvious solution...

@lhecker
Copy link
Member

lhecker commented Feb 24, 2025

The ideal solution I can think of is to group all colors in the viewport, sort them descending by frequency, assign the first one its original color and then nudge every other color to fulfill a given min. distance to every preceding color. Not entirely sure how to do that in a scalable way though.

Edit: Barnes-Hut simulation or Fast Multipole Method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants