Come up with a better solution for reloading tabTitle

[zadjii-msft]

@DHowett-MSFT

tabTitle is the only one it will matter for (and it doesn't work right right now), but this will be lost on a settings reload.

@zadjii-msft

That wouldn't matter though, would it? The startingTitle doesn't work on reload anyways - it's just the title the process starts with.

@DHowett-MSFT

Er that's what I mean when i say "doesn't work right now" -- tabTitle is a weird one where it should totally win if suppressApplicationTitle is turned on, right? So we have a minor issue right now where the tab title never gets pushed down to the right place (Terminal Core right now) on reload.. but this compounds the issue b/c if we DO implement that properly profiles started with this shortcut will have their tab titles lost.

We need to shake this story out, esp. with #3825 merged. If a tab hasn't set the title, and it's still using the initial "tabTitle", then when we hot-reload, we should update that value. If someone's using a title that's provieded as a part of the tabTitle in NewTabArgs, we should also probably use that instead of the settings one on reload.

This also represents work to dig through this story and make sure these settings are really getting plumbed through to the right layers, since we're getting pretty consistent bugs with it.

[zadjii-msft]

Meh, I'm going to say "no one's complained about this". Sure, we could see if a tab has the same title as a changed tabTitle, and then manually change it, but that seems like a lot of work that no one seems to be bothered by.