Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Font prioritization function #5767

Closed
HiSkyZen opened this issue May 6, 2020 · 2 comments
Closed

[Feature Request] Font prioritization function #5767

HiSkyZen opened this issue May 6, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@HiSkyZen
Copy link

HiSkyZen commented May 6, 2020

Description of the new feature/enhancement

As of now, only one font face can be set in Windows Terminal.
ex> "fontFace": "Cascadia Mono"
However, Cascadia Mono does not have any support for CJK text.
However, if we use other fonts, we will not be able to fully experience the beauty of Windows Terminal.
This can happen to CJK users and everyone who doesn't use Latin characters.
So, similar to css' font-family property, we need the ability to set multiple values according to priority in the "fontFace" property of the configuration file.
What about creating a "fontList" array similar to "scheme" so that only the "name" in the object of the "fontList" array is entered for the "fontFace" attribute?
ex>

"fontList": [
    {
        "name": "list1",
        "fontFace1": "Cascadia Mono",
        "fontFace2": "Noto Sans Mono CJK KR"
    }
]
"fontFace": "list1"

Proposed technical implementation details (optional)

@HiSkyZen HiSkyZen added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 6, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 6, 2020
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #2664 for more discussion.

/dup #2664

@ghost
Copy link

ghost commented May 6, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 6, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 6, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants