From e4e62d90e63c1e35feff578e070abe72184461c9 Mon Sep 17 00:00:00 2001 From: Leon Liang Date: Tue, 12 May 2020 10:01:55 -0700 Subject: [PATCH 1/3] removed card suites, male+female sign, smiley face as wides as per CP437 --- src/types/CodepointWidthDetector.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/types/CodepointWidthDetector.cpp b/src/types/CodepointWidthDetector.cpp index ffb30b57412..7fd0d4f9df9 100644 --- a/src/types/CodepointWidthDetector.cpp +++ b/src/types/CodepointWidthDetector.cpp @@ -179,7 +179,6 @@ namespace UnicodeRange{ 0x2592, 0x2595, CodepointWidth::Ambiguous }, UnicodeRange{ 0x25a0, 0x25a1, CodepointWidth::Ambiguous }, UnicodeRange{ 0x25a3, 0x25a9, CodepointWidth::Ambiguous }, - UnicodeRange{ 0x25aa, 0x25ab, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x25b2, 0x25b3, CodepointWidth::Ambiguous }, UnicodeRange{ 0x25b6, 0x25b7, CodepointWidth::Ambiguous }, UnicodeRange{ 0x25bc, 0x25bd, CodepointWidth::Ambiguous }, @@ -204,13 +203,9 @@ namespace UnicodeRange{ 0x2626, 0x2626, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x262a, 0x262a, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x262e, 0x262f, CodepointWidth::Wide }, // OVR - UnicodeRange{ 0x2638, 0x263a, CodepointWidth::Wide }, // OVR - UnicodeRange{ 0x2640, 0x2640, CodepointWidth::Wide }, // OVR - UnicodeRange{ 0x2642, 0x2642, CodepointWidth::Wide }, // OVR + UnicodeRange{ 0x2638, 0x2639, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x2648, 0x2653, CodepointWidth::Wide }, - UnicodeRange{ 0x265f, 0x2660, CodepointWidth::Wide }, // OVR - UnicodeRange{ 0x2663, 0x2663, CodepointWidth::Wide }, // OVR - UnicodeRange{ 0x2665, 0x2666, CodepointWidth::Wide }, // OVR + UnicodeRange{ 0x265f, 0x265f, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x2668, 0x2668, CodepointWidth::Wide }, // OVR UnicodeRange{ 0x2669, 0x266a, CodepointWidth::Ambiguous }, UnicodeRange{ 0x266c, 0x266d, CodepointWidth::Ambiguous }, From 422be68ba36b12945a00626e07f1e23f576b8ead Mon Sep 17 00:00:00 2001 From: Leon Liang Date: Tue, 12 May 2020 10:27:24 -0700 Subject: [PATCH 2/3] comment --- src/types/CodepointWidthDetector.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/types/CodepointWidthDetector.cpp b/src/types/CodepointWidthDetector.cpp index 7fd0d4f9df9..5f6a7c7ea52 100644 --- a/src/types/CodepointWidthDetector.cpp +++ b/src/types/CodepointWidthDetector.cpp @@ -38,6 +38,10 @@ namespace // 0x2666 0x2710, // 0x270E 0x2765 0x1f000 - 0x1f02b except 0x1f004 0x1f594 // + // GH #5822 - Removed glyphs that appear inside of CP437 (https://en.wikipedia.org/wiki/Code_page_437) + // and WGL4 (https://en.wikipedia.org/wiki/Windows_Glyph_List_4) since they've been narrow since the + // beginning of time and changing it to wide would only cause destruction. + // // *** Codepoint ranges marked with "OVR" have their given width from EastAsianWidth.txt overridden. UnicodeRange{ 0xa1, 0xa1, CodepointWidth::Ambiguous }, UnicodeRange{ 0xa4, 0xa4, CodepointWidth::Ambiguous }, From ae6360a6000c1cb79aefe6a791992e3ec0b15776 Mon Sep 17 00:00:00 2001 From: Leon Liang Date: Tue, 12 May 2020 11:15:14 -0700 Subject: [PATCH 3/3] oh spellcheck why must you block me so --- .github/actions/spell-check/whitelist/whitelist.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/spell-check/whitelist/whitelist.txt b/.github/actions/spell-check/whitelist/whitelist.txt index 330b8b24b93..5b4e81fc8f4 100644 --- a/.github/actions/spell-check/whitelist/whitelist.txt +++ b/.github/actions/spell-check/whitelist/whitelist.txt @@ -2632,6 +2632,7 @@ wfdopen WFill wfopen wfstream +WGL WHelper whitelisting WIDTHSCROLL