Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode.previewHtml command failing - promise not resolving if preview tab exists in Insiders build #657

Closed
kevcunnane opened this issue Feb 1, 2017 · 1 comment
Closed

vscode.previewHtml command failing - promise not resolving if preview tab exists in Insiders build #657

kevcunnane opened this issue Feb 1, 2017 · 1 comment
Labels
Bug

Comments

@kevcunnane
Copy link
Contributor

  • MSSQL Extension Version: Any
  • VSCode Version: 1.9.0 Insiders
  • OS Version: Any

This is tracking an upstream blocking issue microsoft/vscode#19654. The vscode.previewHtml command suddenly stopped resolving its promise if the tab already exists. This means that any code in the .then method is not executed. We use this to refresh our contents so until this is fixed, we're blocked in Insiders builds.
@kevcunnane
Copy link
Contributor Author

Closing to use #669 as our main tracking issue for this, since it's a user-raised issue and has updated information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevcunnane