Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable on Jupyter notebooks #86

Open
salcc opened this issue Jul 12, 2023 · 4 comments
Open

Enable on Jupyter notebooks #86

salcc opened this issue Jul 12, 2023 · 4 comments
Labels
feature-request Request for new features or functionality needs community feedback

Comments

@salcc
Copy link

salcc commented Jul 12, 2023

The extension does not lint .ipynb files.

@karthiknadig karthiknadig added feature-request Request for new features or functionality needs community feedback and removed triage-needed labels Jul 12, 2023
@mrclmh
Copy link

mrclmh commented Apr 5, 2024

Is feedback other than a "thumbs up" required?
Is there a defined threshold above which the feature request will be accepted?

@rd-andreas-lay
Copy link

Would be great to have this. I have currently set up my .pre-commit-config.yaml such that notebooks are linted using nbqa:

-   repo: local
    hooks:
     -  id: mypy-jupyter
        name: mypy-jupyter
        entry: nbqa mypy
        language: system
        types: [jupyter]
        require_serial: true

It'd be nice to get linting working directly through the vscode-mypy extension though.

@ninjaguardian
Copy link

It would make it so I don't have to move my code to see if mypy is yelling at me.

@xhiroga
Copy link

xhiroga commented Jul 11, 2024

I've been using nb-mypy as an alternative, but it performs runtime type checking, which tends to slow down execution noticeably. Having static type checking directly within the vscode-mypy extension would be extremely beneficial.
I strongly support the implementation of this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs community feedback
Projects
None yet
Development

No branches or pull requests

6 participants