Command revealFileInOS breaks with Explorer view NOT opened

[ewerybody]

Issue Type: Bug

Found:

Performing the command revealFileInOS fails when the Explorer view Ctrl+Shift+E is NOT visible.

Repro:

• have 2 files in 2 tabs from different directories open
• run revealFileInOS on tab 1
• see the File Browser with the selected file
• close Explorer, the whole Sidebar or switch to Extensions, Debug view ...
• run revealFileInOS on tab 2
• see the File Browser opened with the file from tab 1 selected!

Expected:

revealFileInOS always shows the according file in the File Browser

Interestingly copyFilePath always gives you the correct path of the file in the active tab regardless of the Explorer view state.

VS Code version: Code - Insiders 1.52.0-insider (78908e7, 2020-11-18T12:38:39.842Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: enabled_on protected_video_decode: enabled rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.74GB (9.83GB free)
Process Argv	--crash-reporter-id 0c2cfa5b-5dc2-4a3f-8161-96a200a402ab
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
vbscript	Dar	1.0.4
vsc-python-indent	Kev	1.12.0
python	ms-	2020.11.367453362
vscode-pylance	ms-	2020.11.1
jupyter	ms-	2020.11.358541065
vsliveshare	ms-	1.0.3206
vscode-qt-for-python	sea	0.5.3

(1 theme extensions excluded)

[ewerybody]

Oh I found an even more severe one on that:

• Make a completely new window Ctrl+Shift+N
• save the file Ctrl+S anywhere
• call revealFileInOS (via command pallette or right-click on the tab: "Reveal in File Explorer")
• get this Info popup: Open a file first to reveal
  

The command copyFilePath still works correctly in this situation.

[isidorn]

Yeah we are aware of that.
@bpasero tackled a duplicate of this issue. Currently we have no plans to tackle this further. Thus assigning to backlog

[ewerybody]

OK. I might look into it. Where do I start? 😄

[isidorn]

vscode/src/vs/workbench/contrib/files/electron-sandbox/fileActions.contribution.ts

Line 39 in 936048e

const explorerService = accessor.get(IExplorerService);

Though I am not sure if there is a nice solution...