Integration tests stalled in Emmet tests #162295
Comments
|
Yeah I think the profiler should probably not run in our CI and/or tests. What is more interesting is megabytes of logs being created as part of the run all containing this exception:
But it is hard to say if its caused by profiling or not. |
There is a forgotten console.log-statement but the rest is using the log service and should be proper.
I kinda like that idea. I haven't seen an impact on runtime performance from profiling. Given we can store them as artifacts and given we can signal to the outside that this happened I see value in find issues quickly |
|
Also note that we will disable automatic profiling for stable again |
|
We store pipeline artefacts in the A task to publish artefacts looks like this: vscode/build/azure-pipelines/darwin/product-build-darwin-test.yml Lines 203 to 214 in 96dda01 |
|
Another run https://dev.azure.com/monacotools/Monaco/_build/results?buildId=187196&view=results hitting the root issue. |
|
i plead innocent, my changes are out: no more renderer profiling, no more lone console.log |
|
Same ton of in the logs |
|
sorry, my PR to disable profiling go stuck in the pipeline (#162307). Second attempt is on its way |
|
@bpasero I believe the EPIPE error is happening because I was having a similar error in my application ( const { createWriteStream } = require('fs')
const { tmpdir } = require('os')
let logger
const getOrCreateLogger = () => {
if (!logger) {
const tmpDir = tmpdir()
logger = createWriteStream(`${tmpDir}/log.txt`)
}
return logger
}
process.stdout.on('error', (error) => {
const logger = getOrCreateLogger()
logger.write(`[main-process] stdout error: ${error.stack}`)
})
process.stderr.on('error', (error) => {
const logger = getOrCreateLogger()
logger.write(`[main-process] stderr error: ${error.stack}`)
})This NodeJS issue helped me track down the problem: nodejs/node#831. |
|
@deepak1556 Is this issue still valid after #186717 got merged in? |
|
Haven't seen this in while, can be closed. |
Refs https://dev.azure.com/monacotools/Monaco/_build/results?buildId=187079&view=results
Looks like there are two items that need investigation,
The text was updated successfully, but these errors were encountered: