Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal quick fix - create PR fix suggestion #167738

Closed
lszomoru opened this issue Nov 30, 2022 · 1 comment
Closed

Terminal quick fix - create PR fix suggestion #167738

lszomoru opened this issue Nov 30, 2022 · 1 comment
Assignees
@Tyriar @mjbvz @meganrogge
Labels
*as-designed Described behavior is as designed

Comments

@lszomoru
Copy link
Member

Testing #166761

It took me some time to realize that the link that is being suggested would take me to create a pull request. Instead of showing the long URL could we instead maybe show something along the lines of "Create new Pull Request".
@Tyriar
Copy link
Member

Tyriar commented Nov 30, 2022

Create new pull request is ambiguous whether it will be done integrated or via opening a link. We also wanted to stay away from custom labels to ensure a consistent experience, at least for now, so extensions can only contribute "Run: " and "Open: " currently. @meganrogge let's listen for more similar feedback when extensions start using the API.

@Tyriar Tyriar closed this as completed Nov 30, 2022
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@mjbvz mjbvz

@meganrogge meganrogge

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Tyriar @lszomoru @mjbvz @meganrogge