Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Don't show suggestions when navigating via home/end, ctrl+arrow, etc. #241588

Open
Tyriar opened this issue Feb 22, 2025 · 1 comment
Open

Terminal suggest: Don't show suggestions when navigating via home/end, ctrl+arrow, etc. #241588

Tyriar opened this issue Feb 22, 2025 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Milestone
March 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2025

Repro:

  1. Terminal suggest on
  2. Type code --locale
  3. Press home, cursor goes to start
  4. Press end, cursor goes to end, 🐛 suggest should not show

Image

Home/end sequences need same treatment as horizontal arrows
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Feb 22, 2025
@Tyriar Tyriar added this to the Backlog milestone Feb 22, 2025
@Tyriar Tyriar changed the title Terminal suggest: Don't show suggestions when navigating via home/end Terminal suggest: Don't show suggestions when navigating via home/end, ctrl+arrow, etc. Feb 22, 2025
@Tyriar Tyriar assigned Tyriar and unassigned meganrogge Feb 22, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Feb 22, 2025

We may be able to just check if the last key has \x1b in it and assume it's navigation or something we don't want quick suggestions for? Let's try this in March

@Tyriar Tyriar modified the milestones: Backlog, March 2025 Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-suggest
Projects
None yet
Milestone
March 2025
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge