Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown preview doesn't syntax highlight tsx #36711

Closed
JoshuaKGoldberg opened this issue Oct 22, 2017 · 1 comment
Closed

Markdown preview doesn't syntax highlight tsx #36711

JoshuaKGoldberg opened this issue Oct 22, 2017 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
November 2017

Comments

@JoshuaKGoldberg
Copy link
Contributor

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:38:09.760Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author (truncated) Version
vscode-markdownlint Dav 0.11.0
vscode-eslint dba 1.3.2
python don 0.7.0
tslint eg2 1.0.11
prettier-vscode esb 0.24.0
csharp ms- 1.12.1
typescript-javascript-grammar ms- 0.0.24
debugger-for-chrome msj 3.4.0
Ruby reb 0.15.0
java red 0.12.0
stylelint shi 0.30.0

Steps to Reproduce:

  1. Create a .md file with a ```tsx block:
    image

  2. Open a preview view on that .md file:
    image

Note that it does correctly highlight ts</code> and <code>typescript blocks.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the markdown Markdown support issues label Oct 22, 2017
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) bug Issue identified by VS Code Team member as probable bug labels Oct 23, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 23, 2017

Tracked upstream by highlightjs/highlight.js#1155

@mjbvz mjbvz added this to the November 2017 milestone Nov 10, 2017
@mjbvz mjbvz closed this as completed in 662e0e9 Nov 17, 2017
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@JoshuaKGoldberg @RMacfarlane @mjbvz