Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the "condition" or "hitCondition" on a breakpoint results in a remove and add event #42200

Closed
weinand opened this issue Jan 26, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jan 26, 2018

Editing the "condition" or "hitCondition" on a breakpoint does not preserve the identity of a breakpoint (aka uuid) but results in a remove and then an add event. I would expect to receive a changed event instead (as I do when the enable state changes).

This behaviour is undesirable and surfaces now in the extension API for breakpoints.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 26, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 26, 2018
@isidorn isidorn added the debt Code quality issues label Jan 31, 2018
@isidorn isidorn modified the milestones: January 2018, February 2018 Jan 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

Debt -> will tackle in debt week.
Bascially the updateBreakpoints API needs to work both with DebugProtocl.Breakpoint and with the IRawBreakpoint

@isidorn isidorn closed this as completed in 15d8874 Feb 6, 2018
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants