Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] - Ability to filter problems per root folder in a MR workspace #64481

Closed
fssrepository opened this issue Dec 6, 2018 · 12 comments
Assignees
Labels
error-list Problems view feature-request Request for new features or functionality

Comments

@fssrepository
Copy link

fssrepository commented Dec 6, 2018

v1.29.1

I have analyzed the Problems bar and I'm missing some features:

  1. To be able to filter by projects - (multi-project workspace - some of them might be unrelated and the list can be very long) - however, I see that I can filter by project folder
  2. Filter by Warnings / Error / TODO message - for the last one I'm using a separate TODO tree plugin
    If the TODO would be highlighted also, it won't be necessary to use any external plugin.
  3. Problems should be arranged in a tree-like system (showing folders) - or similar what the Todo Tree plugin is doing (switch between a flat and a hierarchical tree with a button at the top). I had 1500 warnings in my workspace and simply it was too much to read next to the errors and TODO-s, and missed the benefit of the whole Problem tab.
    The tree-like system can be filterable.

I have no idea how to type in "info" in a relation of a folder or project. It's not a regex field.

Can you make a PR on these suggestion pls, as it's not that usable at the moment?

@vscodebot vscodebot bot added the error-list Problems view label Dec 6, 2018
@fssrepository fssrepository changed the title Problems Tab not readable [feature request] - Problems Tab not readable Dec 6, 2018
@sandy081
Copy link
Member

sandy081 commented Dec 6, 2018

To be able to filter by projects - (multi-project workspace - some of them might be unrelated and the list can be very long) - however, I see that I can filter by project folder

You can use glob patterns in the filter box. Eg: /folder1/**

Filter by Warnings / Error / TODO message - for the last one I'm using a separate TODO tree plugin
If the TODO would be highlighted also, it won't be necessary to use any external plugin.

Duplicate of #47354

Problems should be arranged in a tree-like system (showing folders) - or similar what the Todo Tree plugin is doing (switch between a flat and a hierarchical tree with a button at the top). I had 1500 warnings in my workspace and simply it was too much to read next to the errors and TODO-s, and missed the benefit of the whole Problem tab.
The tree-like system can be filterable.

Do you mean like the tree in explorer?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Dec 6, 2018
@fssrepository
Copy link
Author

fssrepository commented Dec 6, 2018

@sandy81

Especially the closed bug was quite important:

v1.29.1

image

I have a multi-root workspace and I would have liked to filter out info/error/todo for a particular project

  1. I have entered 'error, **/server' - and warnings have been shown up
  2. I have entered 'info' - warnings have been shown up even if I have different TODO-s with different info icon - in combination with '**/server' is the same
  3. entered 'warn' which showed me the warnings at the beginning, but also looked for text warning in my TODO info-s

image

I can filter out a project '/server', but I cannot filter out '/server, info' - I would have liked to look for info-s inside the server project. it works independently, but not together.

That's why it's raised in a different bug, as it's not a feature request.

There is a non-intuitive feature, that you can put 'info' in a filter bar, which filters 'info' as a type, not as a text

@fssrepository
Copy link
Author

fssrepository commented Dec 6, 2018

Tree explorer:

At the moment the problem tab is showing a flat tree - showing files (java classes) independently, what I wanted to say in relation to the filter bar it would be nice if there would be a switch button, so you can view a hierarchical tree which showing the folder structure (packages) also, so you can go inside and see the java classes. Maybe the button is not needed just make the packages tree as default.

I might agree with the warn /info/error buttons, I think it might be appearing when you click on that cog icon to make it less dense, however, I would like to see that the combination can work, if I type in.

I'm fine with proper regular expression also, which we haven't on that bar. (it would be much more efficient, than putting buttons on the screen - A developer can expect that scenario in a neutral way, as I have tried out at first whether I can enter a regular expression to that filter bar)

I tried to put '**/server[info]' - '**/server/info' logically without knowing the exact behaviour, but this regular expression shouldn't look for "info" text, just for info as type, you can do it easily by separating with commas.

'**/server', 'info' etc. - maybe the explanation is the solution

@sandy081
Copy link
Member

sandy081 commented Dec 7, 2018

@fssrepository Request you mentioned in this comment is a duplicate of #47354.

I see your requirement to have a tree explorer here. But you can always go to file explorer for this kind of information right? May I know what is missing in the file explorer which you need?

@vscodebot vscodebot bot closed this as completed Dec 14, 2018
@vscodebot
Copy link

vscodebot bot commented Dec 14, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@fssrepository
Copy link
Author

We are talking about the Problem tab, not the file explorer, can I filter in the file explorer for "info" type of message, or "error" or "warn"?

To create a button row on that tiny place is one solution, the second is that to make the problem's filter bar to be able to get half regex, half type, or something similar.

@sandy081 sandy081 reopened this Dec 16, 2018
@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Dec 16, 2018
@sandy081
Copy link
Member

@fssrepository #47354 covers the requirement of filtering by type.

So you want to see a tree that is similar to file explorer but showing those only have problems? This will help you grouping the files by package (for example) in case of java project?

@sandy081 sandy081 added the feature-request Request for new features or functionality label Dec 16, 2018
@fssrepository
Copy link
Author

fssrepository commented Dec 16, 2018

Yes, exactly, however, my initial problem was that in a multi-root workspace, I would have liked to group by project also (filter "error/warn/info" messages by project name), or some nice solution for it. So the #47354 does not cover the multi-root criteria. Because of the so many combinations to extend the filter bar on the problem tab to a regex bar can be a more preferred solution. (or both)

@sandy081 sandy081 changed the title [feature request] - Problems Tab not readable [feature request] - Ability to filter problems per root folder Nov 8, 2019
@sandy081 sandy081 changed the title [feature request] - Ability to filter problems per root folder [feature request] - Ability to filter problems per root folder in a MR workspace Nov 8, 2019
@sandy081
Copy link
Member

sandy081 commented Nov 8, 2019

Changed the title to reflect to what is required.

@sandy081 sandy081 added this to the Backlog Candidates milestone Nov 8, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@vscodebot
Copy link

vscodebot bot commented Mar 16, 2020

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-list Problems view feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants