Adding an ipv6 policy for port mapping policies when dual stack is en… #104
Conversation
cni/cni.go
Outdated
| @@ -355,6 +355,16 @@ func (config *NetworkConfig) GetEndpointInfo( | |||
| logrus.Debugf("Created raw policy from mapping: %+v --- %+v", mapping, policy) | |||
| epInfo.Policies = append(epInfo.Policies, policy) | |||
|
|
|||
| if config.OptionalFlags.EnableDualStack { | |||
| v6flags := flags | 3 | |||
There was a problem hiding this comment.
Does 3 here represent Ipv6 support? Isn't there a constant defined in hcsshim for this
There was a problem hiding this comment.
good catch. just updated the PR with the hcsshim flags
kestratt
force-pushed
the
kestratt/dualstacknatpolicy
branch
from
98984a7 to
9220588
Compare
| NatFlagsNone NatFlags = iota | ||
| NatFlagsLocalRoutedVip | ||
| NatFlagsIPv6 | ||
| var ( |
There was a problem hiding this comment.
We shouldn't be making changes in the vendor repo. We should be making the required changes in https://github.com/microsoft/hcsshim and creating a tag when the changes are merged, then revendor hcsshim in this directory.
This will ensure the changes aren't wiped out in the future due to any version upgrade.
windows-container-networking/go.mod
Line 7 in 0f85901
There was a problem hiding this comment.
Yes, the vendor changes were temporarily made and pushed for validation. Local tests were failing due to infra issues. the hcsshim changes weren't needed. Thanks for the comment!
kestratt
force-pushed
the
kestratt/dualstacknatpolicy
branch
from
04e45fd to
b598c1a
Compare
kestratt
force-pushed
the
kestratt/dualstacknatpolicy
branch
from
b598c1a to
1d17fb7
Compare
…abled
Currently only ipv4 port mapping policies are added to the host for dual stack scenarios. Adding an extra policy without the VIP specified to handle ipv6 traffic. HNS will use the network's management ipv6 as the vip for nat-ing
Validation: