-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Dependencies in GA #1112
Comments
For telemetry tracing in PHP, we are currently using this library [Open telemetry] (https://github.com/open-telemetry/opentelemetry-php). While it might not be a good idea to use a Beta Library to use dependencies that are not on general availability due to potential breaking changes and quality issues, there seem to be no other alternatives at this time. Could we take this approach for this particular case. cc @MIchaelMainer @darrelmiller @baywet @ddyett |
Thanks for flagging this Shem.
Throughts? |
+1 to what Vincent said. If the customer is concerned with capturing traces using OpenTelemetry, they may likely be tracing other parts of their application that are not using MG so they should be aware of the beta quality bar for PHP OpenTelemetry. If a breaking change occurs, it will likely impact their application code at the same time as our SDK code. We should make a note somewhere that we implement OpenTelemetry and that our current instrumentation is based on beta versions of OpenTelemetry for PHP. We should still be defensive in case a listener changes from under us. |
closing since implementation will be tracked under microsoft/kiota#1871 |
Would it be a good idea to use a dependency at Beta for a GA release. The dependency
The text was updated successfully, but these errors were encountered: