Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Dependencies in GA #1112

Closed
shemogumbe opened this issue Jan 11, 2023 · 4 comments
Closed

Beta Dependencies in GA #1112

shemogumbe opened this issue Jan 11, 2023 · 4 comments
Assignees
Labels

Comments

@shemogumbe
Copy link
Contributor

shemogumbe commented Jan 11, 2023

Would it be a good idea to use a dependency at Beta for a GA release. The dependency

@ghost ghost added the ToTriage label Jan 11, 2023
@shemogumbe shemogumbe self-assigned this Jan 11, 2023
@shemogumbe
Copy link
Contributor Author

For telemetry tracing in PHP, we are currently using this library [Open telemetry] (https://github.com/open-telemetry/opentelemetry-php).
The library is currently in Beta, and advises that for long term support we specify dev releases, not even the latest version (Beta)

While it might not be a good idea to use a Beta Library to use dependencies that are not on general availability due to potential breaking changes and quality issues, there seem to be no other alternatives at this time.

Could we take this approach for this particular case. cc @MIchaelMainer @darrelmiller @baywet @ddyett

@baywet
Copy link
Member

baywet commented Jan 11, 2023

Thanks for flagging this Shem.
While we should always be cautious about using anything non GA as a dependency since it will impact our own ability to support our customers, I think this one is fine for a couple of reasons:

  • it implements a standard, which reduces their ability to drastically change the library API surface (has to map to the concepts of the standard).
  • the way it's been implemented in dotnet/go/typescript/java is limited the the kiota abstractions/http/authentication libraries, and it's encapsulated. Should a breaking change arise, we should be able to change our implementation code, and minor or patch bump without impacting the customers experience.

Throughts?

@MIchaelMainer
Copy link
Contributor

MIchaelMainer commented Jan 11, 2023

+1 to what Vincent said.

If the customer is concerned with capturing traces using OpenTelemetry, they may likely be tracing other parts of their application that are not using MG so they should be aware of the beta quality bar for PHP OpenTelemetry. If a breaking change occurs, it will likely impact their application code at the same time as our SDK code.

We should make a note somewhere that we implement OpenTelemetry and that our current instrumentation is based on beta versions of OpenTelemetry for PHP.

We should still be defensive in case a listener changes from under us.

@Ndiritu
Copy link
Contributor

Ndiritu commented Feb 23, 2023

closing since implementation will be tracked under microsoft/kiota#1871

@Ndiritu Ndiritu closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants