Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing arg "groupBy?" at exported attachPropertyDataToClass in decoratorManager #1146

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

singlebyted
Copy link
Contributor

Checklist
  • npm test passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@midway/decorator

Description of change

Added missing arg "groupBy?" at exported attachPropertyDataToClass in decoratorManager.

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #1146 (a48e4f0) into 2.x (8e55373) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #1146   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         221      221           
  Lines        8808     8808           
  Branches     1748     1748           
=======================================
  Hits         7540     7540           
  Misses       1206     1206           
  Partials       62       62           
Impacted Files Coverage Δ
packages/decorator/src/common/decoratorManager.ts 95.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e55373...a48e4f0. Read the comment docs.

@czy88840616 czy88840616 merged commit f4f7a55 into midwayjs:2.x Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants