Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decorator manager singleton #1211

Merged
merged 2 commits into from
Aug 7, 2021
Merged

fix: decorator manager singleton #1211

merged 2 commits into from
Aug 7, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Aug 7, 2021

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #1211 (30c6491) into 2.x (c982a10) will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #1211      +/-   ##
==========================================
+ Coverage   85.20%   85.27%   +0.07%     
==========================================
  Files         232      236       +4     
  Lines        9024     9157     +133     
  Branches     1710     1735      +25     
==========================================
+ Hits         7689     7809     +120     
- Misses       1268     1281      +13     
  Partials       67       67              
Impacted Files Coverage Δ
packages/decorator/src/common/decoratorManager.ts 95.09% <50.00%> (-0.32%) ⬇️
packages/ws/src/framework.ts 92.30% <100.00%> (ø)
packages-serverless/serverless-app/src/platform.ts 100.00% <0.00%> (ø)
...erverless/serverless-vercel-starter/src/runtime.ts 87.50% <0.00%> (ø)
...s-serverless/serverless-vercel-trigger/src/http.ts 95.65% <0.00%> (ø)
...-serverless/serverless-vercel-starter/src/index.ts 91.66% <0.00%> (ø)
...-serverless/serverless-vercel-trigger/src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c982a10...30c6491. Read the comment docs.

@czy88840616 czy88840616 merged commit 7e9150e into 2.x Aug 7, 2021
@czy88840616 czy88840616 deleted the fix_decorator_singleton branch August 7, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants