Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace configuration.imports to object directly and deprecated string #657

Merged
merged 14 commits into from
Oct 8, 2020

Conversation

czy88840616
Copy link
Member

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2020

@czy88840616 czy88840616 changed the title feat: replace configuration.imports to object directly feat: replace configuration.imports to object directly and deprecated string Oct 2, 2020
@czy88840616 czy88840616 force-pushed the add_load_obj_configuration branch 3 times, most recently from f2c07d4 to d41824e Compare October 5, 2020 16:11
@czy88840616 czy88840616 force-pushed the add_load_obj_configuration branch from d41824e to bdb5352 Compare October 8, 2020 13:02
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #657 into 2.x will increase coverage by 1.33%.
The diff coverage is 89.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #657      +/-   ##
==========================================
+ Coverage   82.40%   83.73%   +1.33%     
==========================================
  Files         101      102       +1     
  Lines        4274     4305      +31     
  Branches      687      693       +6     
==========================================
+ Hits         3522     3605      +83     
+ Misses        719      666      -53     
- Partials       33       34       +1     
Impacted Files Coverage Δ
packages/core/src/common/constants.ts 100.00% <ø> (ø)
packages/core/src/common/util.ts 100.00% <ø> (ø)
packages/core/src/context/container.ts 100.00% <ø> (ø)
packages/core/src/context/resolverHandler.ts 100.00% <ø> (ø)
packages/core/src/interface.ts 100.00% <ø> (ø)
...ges/decorator/src/microservice/rabbitmqListener.ts 100.00% <ø> (ø)
packages/rabbitmq/src/framework.ts 97.50% <ø> (+2.15%) ⬆️
packages/socketio/src/framework.ts 89.04% <ø> (+0.88%) ⬆️
packages/web-express/src/framework.ts 69.23% <ø> (+0.05%) ⬆️
packages/web-koa/src/framework.ts 69.85% <ø> (+0.06%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e768ee8...f3aef00. Read the comment docs.

@czy88840616 czy88840616 merged commit f1b42a1 into 2.x Oct 8, 2020
@czy88840616 czy88840616 deleted the add_load_obj_configuration branch October 8, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants