Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support https config for web/koa/express #742

Merged
merged 4 commits into from
Dec 26, 2020
Merged

Conversation

czy88840616
Copy link
Member

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Dec 4, 2020

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #742 (598f0e6) into 2.x (87247ea) will decrease coverage by 0.59%.
The diff coverage is 19.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #742      +/-   ##
==========================================
- Coverage   86.61%   86.02%   -0.60%     
==========================================
  Files         142      142              
  Lines        5814     5867      +53     
  Branches     1081     1108      +27     
==========================================
+ Hits         5036     5047      +11     
- Misses        746      788      +42     
  Partials       32       32              
Impacted Files Coverage Δ
packages/web-express/src/framework.ts 70.28% <16.66%> (-7.40%) ⬇️
packages/web-koa/src/framework.ts 72.34% <16.66%> (-7.50%) ⬇️
packages/web/src/devFramework.ts 50.00% <25.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87247ea...598f0e6. Read the comment docs.

@czy88840616 czy88840616 changed the title feat: support https config feat: support https config for web/koa/express Dec 26, 2020
@czy88840616 czy88840616 merged commit a0c07b9 into 2.x Dec 26, 2020
@czy88840616 czy88840616 deleted the support_https branch December 26, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants