Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed tag order is not preserved #3116

Open
Phantop opened this issue Jan 30, 2025 · 6 comments · May be fixed by #3159
Open

Feed tag order is not preserved #3116

Phantop opened this issue Jan 30, 2025 · 6 comments · May be fixed by #3159

Comments

@Phantop
Copy link
Contributor

Phantop commented Jan 30, 2025

Miniflux currently shows tags at the top of each entry, taken from e.g. the mrss 'category' field. However, it appears that these tags are alphabetized before they're shown. This is problematic, as certain feeds (e.g. those from Tumblr) intend for feeds to be seen in a specific order. I feel like this should not be default behavior—in fact, I recall it previously not being Miniflux's behavior and am rather baffled that it was changed.

@fguillot
Copy link
Member

However, it appears that these tags are alphabetized before they're shown. This is problematic, as certain feeds (e.g. those from Tumblr) intend for feeds to be seen in a specific order.

I don't get it. Why the order is important?

For the latest entry of the sample feed provided, I can see this in the feed:

<category>tumblr tuesday</category>
<category>balatro</category>
<category>balatro joker</category>
<category>artists on tumblr</category>
<category>gaming artists</category>
<category>long post</category>

Which is rendered in alphabetical order in the web ui:

Image

@Phantop
Copy link
Contributor Author

Phantop commented Jan 30, 2025

Oh I suppose that was a bad example—tried using a generic one without checking. Sorry about that.

Commonly, Tumblr tags are used for additional comments on posts and said comments can comprise multiple tags forming multiple complete sentences.

Example: This feed, latest post, and on my Miniflux instance.

@Phantop
Copy link
Contributor Author

Phantop commented Feb 10, 2025

Any update on whether this behavior might be adjusted?

@Phantop
Copy link
Contributor Author

Phantop commented Feb 16, 2025

I did some digging and found that commit 863a5b3 introduced the change in behavior. Would it be reasonable to revert this or make this behavior an option?

@Phantop Phantop linked a pull request Feb 16, 2025 that will close this issue
5 tasks
@jvoisin
Copy link
Collaborator

jvoisin commented Feb 17, 2025

Seems reasonable. Maybe add a comment about not changing the order of the fields?

@Phantop
Copy link
Contributor Author

Phantop commented Feb 17, 2025

Seems reasonable. Maybe add a comment about not changing the order of the fields?

Just updated the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants