From defcc6c7cbe66fb755ad2cb8cb4929daf5d05677 Mon Sep 17 00:00:00 2001 From: Mike Brennan Date: Wed, 24 Jul 2024 13:10:29 +0100 Subject: [PATCH 1/2] update initialdelayseconds default logic --- charts/standard-application-stack/CHANGELOG.md | 4 ++++ charts/standard-application-stack/Chart.yaml | 2 +- charts/standard-application-stack/README.md | 2 +- .../standard-application-stack/templates/deployment.yaml | 8 ++++++-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/charts/standard-application-stack/CHANGELOG.md b/charts/standard-application-stack/CHANGELOG.md index 2b25d300..8912dcea 100644 --- a/charts/standard-application-stack/CHANGELOG.md +++ b/charts/standard-application-stack/CHANGELOG.md @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [v7.2.0] - 2024-07-24 +### Changes +- Updated the logic of initialDelaySeconds to not be set if no value given + ## [v7.1.0] - 2024-07-19 ### Added - Always add `matchLabelKeys: pod-template-hash` to topologySpreadConstraints diff --git a/charts/standard-application-stack/Chart.yaml b/charts/standard-application-stack/Chart.yaml index e75bd7f0..114f61ca 100644 --- a/charts/standard-application-stack/Chart.yaml +++ b/charts/standard-application-stack/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 7.1.0 +version: 7.2.0 dependencies: - name: redis diff --git a/charts/standard-application-stack/README.md b/charts/standard-application-stack/README.md index ca1760b8..27101fe5 100644 --- a/charts/standard-application-stack/README.md +++ b/charts/standard-application-stack/README.md @@ -1,6 +1,6 @@ # standard-application-stack -![Version: 7.1.0](https://img.shields.io/badge/Version-7.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) +![Version: 7.2.0](https://img.shields.io/badge/Version-7.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) A generic chart to support most common application requirements diff --git a/charts/standard-application-stack/templates/deployment.yaml b/charts/standard-application-stack/templates/deployment.yaml index e0ad641c..16f45cda 100644 --- a/charts/standard-application-stack/templates/deployment.yaml +++ b/charts/standard-application-stack/templates/deployment.yaml @@ -287,7 +287,9 @@ spec: port: {{ .Values.liveness.port | default "http" }} scheme: {{ .Values.liveness.scheme | default "HTTP" }} {{- end }} - initialDelaySeconds: {{ .Values.liveness.initialDelaySeconds | default 0 }} + {{- if .Values.liveness.initialDelaySeconds }} + initialDelaySeconds: {{ .Values.liveness.initialDelaySeconds }} + {{- end }} timeoutSeconds: {{ .Values.liveness.timeoutSeconds | default 1 }} periodSeconds: {{ .Values.liveness.periodSeconds | default 10 }} startupProbe: @@ -325,7 +327,9 @@ spec: port: {{ .Values.readiness.port | default "http" }} scheme: {{ .Values.readiness.scheme | default "HTTP" }} {{- end }} - initialDelaySeconds: {{ .Values.readiness.initialDelaySeconds | default 0 }} + {{- if .Values.readiness.initialDelaySeconds }} + initialDelaySeconds: {{ .Values.readiness.initialDelaySeconds }} + {{- end }} timeoutSeconds: {{ .Values.readiness.timeoutSeconds | default 1 }} periodSeconds: {{ .Values.readiness.periodSeconds | default 10 }} {{- end }} From f22271d3c32fc50bdadaae88364315b892ce71e5 Mon Sep 17 00:00:00 2001 From: Mike Brennan Date: Wed, 24 Jul 2024 13:16:31 +0100 Subject: [PATCH 2/2] update snapshot for tests --- .../deployment_dynamodb_enabled_test.yaml.snap | 6 ------ .../tests/__snapshot__/deployment_env_test.yaml.snap | 4 ---- .../deployment_host_network_test.yaml.snap | 2 -- .../deployment_instrumentation_test.yaml.snap | 8 -------- .../__snapshot__/deployment_labels_test.yaml.snap | 4 ---- .../__snapshot__/deployment_lifecycle_test.yaml.snap | 6 ------ .../deployment_mariadb_enabled_test.yaml.snap | 6 ------ .../deployment_memcached_enabled_test.yaml.snap | 6 ------ .../tests/__snapshot__/deployment_ports_test.yaml.snap | 10 ---------- .../__snapshot__/deployment_replicas_test.yaml.snap | 10 ---------- .../__snapshot__/deployment_s3_enabled_test.yaml.snap | 10 ---------- .../deployment_stateful_set_test.yaml.snap | 2 -- .../tests/__snapshot__/ingress_test.yaml.snap | 2 -- .../tests/__snapshot__/oauth2proxy_test.yaml.snap | 10 ---------- .../tests/__snapshot__/pod_monitor_test.yaml.snap | 4 ---- .../tests/__snapshot__/service_monitor_test.yaml.snap | 4 ---- 16 files changed, 94 deletions(-) diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_dynamodb_enabled_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_dynamodb_enabled_test.yaml.snap index f7d93585..02b5eda8 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_dynamodb_enabled_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_dynamodb_enabled_test.yaml.snap @@ -63,7 +63,6 @@ Check DynamoDB envfrom secretRef is present: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Check DynamoDB envfrom secretRef is present: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -184,7 +182,6 @@ Check DynamoDB envfrom secretRef is present for local environment: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -196,7 +193,6 @@ Check DynamoDB envfrom secretRef is present for local environment: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -289,7 +285,6 @@ Check DynamoDB secretName Override: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -301,7 +296,6 @@ Check DynamoDB secretName Override: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_env_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_env_test.yaml.snap index 477f870f..f23e431e 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_env_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_env_test.yaml.snap @@ -162,7 +162,6 @@ Check default env behavior: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -174,7 +173,6 @@ Check default env behavior: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -281,7 +279,6 @@ Check main container combines default env and `main.env` values: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -293,7 +290,6 @@ Check main container combines default env and `main.env` values: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_host_network_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_host_network_test.yaml.snap index 7a0bb99a..87fe35a6 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_host_network_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_host_network_test.yaml.snap @@ -63,7 +63,6 @@ Has a pod template that uses the host network: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Has a pod template that uses the host network: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_instrumentation_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_instrumentation_test.yaml.snap index f5b4d6ce..e9e94094 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_instrumentation_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_instrumentation_test.yaml.snap @@ -83,7 +83,6 @@ Check custom python otel extraEnv vars are added: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -95,7 +94,6 @@ Check custom python otel extraEnv vars are added: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -218,7 +216,6 @@ Check custom sampler settings: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -230,7 +227,6 @@ Check custom sampler settings: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -351,7 +347,6 @@ Check default python otel envars are added: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -363,7 +358,6 @@ Check default python otel envars are added: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -486,7 +480,6 @@ Check global otel extraEnv vars are added: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -498,7 +491,6 @@ Check global otel extraEnv vars are added: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_labels_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_labels_test.yaml.snap index aab67a12..9f76d13e 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_labels_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_labels_test.yaml.snap @@ -65,7 +65,6 @@ Check default label behavior: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -77,7 +76,6 @@ Check default label behavior: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -182,7 +180,6 @@ Check empty application and component labels both default to name: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -194,7 +191,6 @@ Check empty application and component labels both default to name: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_lifecycle_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_lifecycle_test.yaml.snap index 04a8afed..d9f4721b 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_lifecycle_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_lifecycle_test.yaml.snap @@ -76,7 +76,6 @@ Check AWS ALB lifecycle rule applied: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -88,7 +87,6 @@ Check AWS ALB lifecycle rule applied: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -204,7 +202,6 @@ Check AWS ALB lifecycle rules applied with custom delay: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -216,7 +213,6 @@ Check AWS ALB lifecycle rules applied with custom delay: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -324,7 +320,6 @@ Check lifecycle rules: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -336,7 +331,6 @@ Check lifecycle rules: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_mariadb_enabled_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_mariadb_enabled_test.yaml.snap index 67fa1fdc..907102db 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_mariadb_enabled_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_mariadb_enabled_test.yaml.snap @@ -63,7 +63,6 @@ Check MariaDB envfrom secretRef is present: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Check MariaDB envfrom secretRef is present: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -184,7 +182,6 @@ Check MariaDB envfrom secretRef is present for local environment: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -196,7 +193,6 @@ Check MariaDB envfrom secretRef is present for local environment: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -289,7 +285,6 @@ Check MariaDB secretName Override: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -301,7 +296,6 @@ Check MariaDB secretName Override: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_memcached_enabled_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_memcached_enabled_test.yaml.snap index 9c0820af..8eb18292 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_memcached_enabled_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_memcached_enabled_test.yaml.snap @@ -63,7 +63,6 @@ Check Memcached envfrom secretRef is present: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Check Memcached envfrom secretRef is present: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -184,7 +182,6 @@ Check Memcached envfrom secretRef is present for local environment: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -196,7 +193,6 @@ Check Memcached envfrom secretRef is present for local environment: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -289,7 +285,6 @@ Check Memcached secretName Override: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -301,7 +296,6 @@ Check Memcached secretName Override: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_ports_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_ports_test.yaml.snap index a8f70c99..0c651ac6 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_ports_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_ports_test.yaml.snap @@ -63,7 +63,6 @@ Check container extraPorts: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -79,7 +78,6 @@ Check container extraPorts: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -182,7 +180,6 @@ Check container extraPorts are validated: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -200,7 +197,6 @@ Check container extraPorts are validated: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -303,7 +299,6 @@ Check container extraPorts protocol: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -320,7 +315,6 @@ Check container extraPorts protocol: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -423,7 +417,6 @@ Check default container main port: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -435,7 +428,6 @@ Check default container main port: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -538,7 +530,6 @@ Check overridden container main port: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -550,7 +541,6 @@ Check overridden container main port: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_replicas_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_replicas_test.yaml.snap index e857baf9..6341df2d 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_replicas_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_replicas_test.yaml.snap @@ -64,7 +64,6 @@ Check allowSingleReplica doesn't alter strategy: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -76,7 +75,6 @@ Check allowSingleReplica doesn't alter strategy: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -180,7 +178,6 @@ Check allowSingleReplica set annotations: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -192,7 +189,6 @@ Check allowSingleReplica set annotations: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -294,7 +290,6 @@ Check replicas unset when autoscaling is enabled: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -306,7 +301,6 @@ Check replicas unset when autoscaling is enabled: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -407,7 +401,6 @@ Check singleReplicaOnly applied: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -419,7 +412,6 @@ Check singleReplicaOnly applied: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -520,7 +512,6 @@ Check singleReplicaOnly ignore replicas value: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -532,7 +523,6 @@ Check singleReplicaOnly ignore replicas value: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_s3_enabled_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_s3_enabled_test.yaml.snap index e84a46d1..305642d3 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_s3_enabled_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_s3_enabled_test.yaml.snap @@ -63,7 +63,6 @@ Check S3 envfrom secretRef is present: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Check S3 envfrom secretRef is present: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -184,7 +182,6 @@ Check S3 envfrom secretRef is present for local environment: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -196,7 +193,6 @@ Check S3 envfrom secretRef is present for local environment: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -296,7 +292,6 @@ Check S3 envfrom secretRef is present for multiple instances of TF Cloud helm ch path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -308,7 +303,6 @@ Check S3 envfrom secretRef is present for multiple instances of TF Cloud helm ch path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -412,7 +406,6 @@ Check S3 secretName Override: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -424,7 +417,6 @@ Check S3 secretName Override: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -538,7 +530,6 @@ Check S3 stakater secret reloader annotation contains correct secrets for multip path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -550,7 +541,6 @@ Check S3 stakater secret reloader annotation contains correct secrets for multip path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/deployment_stateful_set_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/deployment_stateful_set_test.yaml.snap index f3483da6..f462c710 100644 --- a/charts/standard-application-stack/tests/__snapshot__/deployment_stateful_set_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/deployment_stateful_set_test.yaml.snap @@ -58,7 +58,6 @@ Check stateful set is rendered with volumeClaimTemplates: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -70,7 +69,6 @@ Check stateful set is rendered with volumeClaimTemplates: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/ingress_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/ingress_test.yaml.snap index e156eba5..baccd3de 100644 --- a/charts/standard-application-stack/tests/__snapshot__/ingress_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/ingress_test.yaml.snap @@ -405,7 +405,6 @@ Check EXTRA_ALLOWED_HOSTS env var extraHosts with extraIngresses: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -417,7 +416,6 @@ Check EXTRA_ALLOWED_HOSTS env var extraHosts with extraIngresses: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/oauth2proxy_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/oauth2proxy_test.yaml.snap index d5a72f60..3422f64e 100644 --- a/charts/standard-application-stack/tests/__snapshot__/oauth2proxy_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/oauth2proxy_test.yaml.snap @@ -63,7 +63,6 @@ Check default container args: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -75,7 +74,6 @@ Check default container args: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -235,7 +233,6 @@ Check setting skip-auth-regex from extra passed in values: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -247,7 +244,6 @@ Check setting skip-auth-regex from extra passed in values: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -408,7 +404,6 @@ Check setting skip-auth-regex from extra passed in values when they already cont path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -420,7 +415,6 @@ Check setting skip-auth-regex from extra passed in values when they already cont path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -581,7 +575,6 @@ Check setting skip-auth-regex from overridden health-check values: path: /healthz-overridden port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -593,7 +586,6 @@ Check setting skip-auth-regex from overridden health-check values: path: /readiness-overridden port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -753,7 +745,6 @@ Check sidecar present if enabled: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -765,7 +756,6 @@ Check sidecar present if enabled: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/pod_monitor_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/pod_monitor_test.yaml.snap index 5089238d..5c0a04e0 100644 --- a/charts/standard-application-stack/tests/__snapshot__/pod_monitor_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/pod_monitor_test.yaml.snap @@ -244,7 +244,6 @@ Check combined template defaults: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -256,7 +255,6 @@ Check combined template defaults: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -411,7 +409,6 @@ Check combined template with extra ports and monitors: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -427,7 +424,6 @@ Check combined template with extra ports and monitors: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: diff --git a/charts/standard-application-stack/tests/__snapshot__/service_monitor_test.yaml.snap b/charts/standard-application-stack/tests/__snapshot__/service_monitor_test.yaml.snap index a175ada5..8de05e50 100644 --- a/charts/standard-application-stack/tests/__snapshot__/service_monitor_test.yaml.snap +++ b/charts/standard-application-stack/tests/__snapshot__/service_monitor_test.yaml.snap @@ -295,7 +295,6 @@ Check combined template defaults: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -307,7 +306,6 @@ Check combined template defaults: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: @@ -494,7 +492,6 @@ Check combined template with extra ports and monitors: path: /healthz port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 name: main @@ -510,7 +507,6 @@ Check combined template with extra ports and monitors: path: /readiness port: http scheme: HTTP - initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 1 resources: