Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misskey-js、bubble-game、reversiのビルドをesbuildに統合する #13599

Closed
1 task done
samunohito opened this issue Mar 20, 2024 · 1 comment · Fixed by #13600
Closed
1 task done

misskey-js、bubble-game、reversiのビルドをesbuildに統合する #13599

samunohito opened this issue Mar 20, 2024 · 1 comment · Fixed by #13600
Assignees
Labels
🛠️Dev Development of Misskey itself ✨Feature This adds/improves/enhances a feature

Comments

@samunohito
Copy link
Member

Summary

【変更前】

  • misskey-js
    • pnpm build:tscによるトランスパイルと型定義生成
    • pnpm dev:nodemonによる変更検知&検知したらbuildを起動
  • bubble-game / reversi
    • pnpm build:esbuildによるトランスパイルのみ(型定義生成なし)
    • pnpm dev:nodemonによる変更検知&検知したらtscによるトランスパイルと型定義生成

【変更後】

misskey-js、bubble-game、reversiともに

  • pnpm build:esbuildによるトランスパイル&tscによる型定義生成
  • pnpm dev:esbuildによる変更検知&検知したらbuildを起動

…としたいです。

Purpose

  • pnpm devの起動高速化
  • 変更検知時の再ビルド高速化
  • ビルド方法乱立解消による開発体験向上

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@samunohito samunohito added the ✨Feature This adds/improves/enhances a feature label Mar 20, 2024
@samunohito samunohito self-assigned this Mar 20, 2024
@samunohito
Copy link
Member Author

misskey-js、bubble-game、reversiともに
pnpm build:esbuildによるトランスパイル&tscによる型定義生成

productionビルド時は型定義を作らないようにもしようかと(使わないはず)
misskey-jsのpublishは本体のproduction環境ではやらないと思うので、これも型定義は不要なはず

@t1nyb0x t1nyb0x moved this to Triage in [FEATURE] Dev Mar 23, 2024
@t1nyb0x t1nyb0x moved this from Triage to In Progress in [FEATURE] Dev Mar 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [FEATURE] Dev Mar 30, 2024
@samunohito samunohito added the 🛠️Dev Development of Misskey itself label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Dev Development of Misskey itself ✨Feature This adds/improves/enhances a feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant