Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メンションのユーザーアイコンがデータセーバーをオンにしてても動く #14663

Closed
1 task
KisaragiEffective opened this issue Oct 1, 2024 · 3 comments · Fixed by #14674
Labels
⚠️bug? This might be a bug packages/frontend Client side specific issue/PR

Comments

@KisaragiEffective
Copy link
Collaborator

💡 Summary

メンションのユーザーアイコンがデータセーバーをオンにしてても動く

🥰 Expected Behavior

動かない

🤬 Actual Behavior

メンションのユーザーアイコンがアニメーション禁止にしてても動く

📝 Steps to Reproduce

  1. 全般 > データセーバー > アイコン画像のアニメーションを無効化
  2. https://mi.7mi.site/notes/9ytiwkjpcw2y0pcz を見る
  3. https://mi.7mi.site/proxy/avatar.webp?url=https%3A%2F%2Fmedia.misskeyusercontent.com%2Fio%2Fe3298318-9e58-4e12-a39e-a86be96795b8.gif&avatar=1&static=1 に加えて https://mi.7mi.site/avatar/@[email protected] にもリクエストが飛んでいることを確認する

💻 Frontend Environment

* Model and OS of the device(s): Debian 12
* Browser: Firefox 129.0.2
* Server URL: https://mi.7mi.site/
* Misskey: 2024.9.0

🛰 Backend Environment (for server admin)

n/a (not an admin)

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@KisaragiEffective KisaragiEffective added ⚠️bug? This might be a bug packages/frontend Client side specific issue/PR labels Oct 1, 2024
@KisaragiEffective
Copy link
Collaborator Author

これ仕様な気がしてきた

@KisaragiEffective
Copy link
Collaborator Author

if (defaultStore.state.disableShowingAnimatedImages || defaultStore.state.dataSaver.avatar) return getStaticImageUrl(props.user.avatarUrl);

const avatarUrl = computed(() => defaultStore.state.disableShowingAnimatedImages
? getStaticImageUrl(`/avatar/@${props.username}@${props.host}`)
: `/avatar/@${props.username}@${props.host}`,

@KisaragiEffective
Copy link
Collaborator Author

defaultStore.state.dataSaver.avatar が入ってないのが原因ぽい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug packages/frontend Client side specific issue/PR
Projects
None yet
1 participant