enhance(federation): use ActivityPub defined property in favour of proprietary property. #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann150
added
packages/backend
|
p1.a9z.devに適用してみた |
|
👍🏻 |
Closed
|
you could/should probably use json-ld contexts to provide the migration path via aliases |
Jeder321
pushed a commit
to Jeder321/misskey
that referenced
this pull request
Jul 13, 2022
Fix a regression from misskey-dev#8787 that was previously fixed in misskey-dev#8440.
nullobsi
pushed a commit
to nullobsi/misskey
that referenced
this pull request
Feb 14, 2023
As already noted back in misskey-dev#8787 the intention was to replace the `_misskey_content` attribute with the ActivityPub-defined `source` property. Misskey and by extension Foundkey have shipped with the `source` property and the respective parsing for quite a while so it seems reasonable to remove it now. Changelog: Removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add ActivityPub
sourceproperty.For now this continues to write and read the
_misskey_contentproperty. This change is therefore fully backward compatible.Why
related to #8785. This PR does not completely fix that issue yet: The
_misskey_contentattribute should be removed in the future. I think we should wait at least 3 months after initial release of this change before removing_misskey_content.