Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constants for word32, word64, word128 #135

Closed
JasonGross opened this issue Mar 30, 2017 · 3 comments
Closed

Remove constants for word32, word64, word128 #135

JasonGross opened this issue Mar 30, 2017 · 3 comments
Assignees

Comments

@JasonGross
Copy link
Collaborator

Currently there's a decent amount of code in src/Util/FixedWordSizes.v and src/Util/FixedWordSizesEquality.v that allows us to have separate word32, word64, and word128 constants without treating those cases specially when we use them. We did this so we could extract them to separate things. In the new refinement-based system, do we want to keep them (there is minimal additional cost incurred in keeping them), or do we want to strip them out and have less code, possibly as part of #14?

(The most important thing in the short term is to be consistent about which notion of word we're using.)

@andres-erbsen
Copy link
Contributor

I thought we were going to use { z:Z | 0 <= z < 2^64 } as the word type for some reason you cared about. Either way, I dont think we need these definitions anymore. Independently, I think we might later want to support arbitrary types that behave like { z:Z | A <= z < B } for some A and B, but let's see about that when we get there.

@JasonGross
Copy link
Collaborator Author

I think we should leave this open as a reminder, possibly renaming it; I'm going to prioritize finishing the admitted proofs and integration over removing this code.

@JasonGross JasonGross reopened this Mar 31, 2017
@andres-erbsen andres-erbsen changed the title Do we want separate constants for word32, word64, word128? Remove constants for word32, word64, word128? May 15, 2017
@andres-erbsen andres-erbsen changed the title Remove constants for word32, word64, word128? Remove constants for word32, word64, word128 May 15, 2017
@JasonGross
Copy link
Collaborator Author

This will be closed once we switch over to the new pipeline from #373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants