Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned the boolean usage in MLCFlow #246

Merged
merged 11 commits into from
Feb 20, 2025
Merged

Cleaned the boolean usage in MLCFlow #246

merged 11 commits into from
Feb 20, 2025

Conversation

Sid9993
Copy link

@Sid9993 Sid9993 commented Feb 19, 2025

No description provided.

@Sid9993 Sid9993 requested a review from a team as a code owner February 19, 2025 18:30
Copy link
Contributor

github-actions bot commented Feb 19, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng
Copy link
Contributor

Hi @Sid9993 , I think the import should be slightly different. You can find reference here:

@anandhu-eng
Copy link
Contributor

The changes looks good to me. @Sid9993 , if possible could you add the same for rest of the scripts?

I have managed to find few scripts that might require changes:
https://github.com/search?q=repo%3Amlcommons%2Fmlperf-automations+%22no%22%2C+%22false%22&type=code

Copy link
Contributor

@anandhu-eng anandhu-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the requested change, the PR looks good to me

@arjunsuresh arjunsuresh merged commit de26510 into mlcommons:dev Feb 20, 2025
116 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants