Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message about dropDups #1103

Closed
evanchooly opened this issue Dec 9, 2016 · 0 comments
Closed

Update message about dropDups #1103

evanchooly opened this issue Dec 9, 2016 · 0 comments
Labels
docs enhancement
Milestone
1.3.1

Comments

@evanchooly
Copy link
Member

The current message says to set the value to false rather than just removing that expression altogether. Setting it to false explicitly still leaves a reference to that member in the code which will necessitate a code update when the deprecations are ultimately removed.
@evanchooly evanchooly added this to the 1.3.1 milestone Dec 9, 2016
evanchooly pushed a commit that referenced this issue Dec 9, 2016
update warning about dropDups to encourage removal of references to t…
f0ef650 
…he deprectated field rather than setting it to false explicitly

fixes #1103
@evanchooly evanchooly mentioned this issue Dec 9, 2016
Merged
evanchooly added a commit that referenced this issue Dec 12, 2016
@evanchooly
update warning about dropDups to encourage removal of references to t…
76491c5 
…he deprectated field rather than setting it to false explicitly (#1106)

fixes #1103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
1 participant
@evanchooly