Added type safety to the GeometryShapeConverter. #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al of odd subtle bugs. This exposed the fact that there was a call to decode something that didn't need decoding.
| } | ||
| return getMapper().getConverters().encode(fromDBObject); |
There was a problem hiding this comment.
This call was unnecessary, and probably wrong - calling encode from inside the decode method was suspicious, and in fact all you need is to add the last fromDBObject to the decodedObjects list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the potential of odd subtle bugs and exposed the fact that there was a call to encode something that didn't need encoding.