Merge pull request mozilla#7897 from Snuffleupagus/eslint-switch

Switch to using ESLint, instead of JSHint, for linting

.eslintrc

@@ -0,0 +1,108 @@
+{
+  "parserOptions": {
+    "ecmaVersion": 5,
+  },
+
+  "env": {
+    "browser": true,
+    "es6": true,
+    "worker": true,
+    "amd": true,
+  },
+
+  globals: {
+    "PDFJSDev": false,
+    "require": false,
+    "exports": false,
+  },
+
+  "rules": {
+    // Possible errors
+    "no-cond-assign": ["error", "except-parens"],
+    "no-constant-condition": ["error", { "checkLoops": false, }],
+    "no-dupe-args": "error",
+    "no-dupe-keys": "error",
+    "no-duplicate-case": "error",
+    "no-empty": ["error", { "allowEmptyCatch": true, }],
+    "no-ex-assign": "error",
+    "no-extra-boolean-cast": "error",
+    "no-extra-semi": "error",
+    "no-func-assign": "error",
+    "no-inner-declarations": ["error", "functions"],
+    "no-invalid-regexp": "error",
+    "no-irregular-whitespace": "error",
+    "no-obj-calls": "error",
+    "no-regex-spaces": "error",
+    "no-sparse-arrays": "error",
+    "no-unexpected-multiline": "error",
+    "no-unreachable": "error",
+    "no-unsafe-negation": "error",
+    "use-isnan": "error",
+    "valid-typeof": ["error", { "requireStringLiterals": true, }],
+
+    // Best Practices
+    "accessor-pairs": ["error", { "setWithoutGet": true, }],
+    "curly": ["error", "all"],
+    "eqeqeq": ["error", "always"],
+    "no-caller": "error",
+    "no-eval": "error",
+    "no-extend-native": "error",
+    "no-extra-bind": "error",
+    "no-extra-label": "error",
+    "no-fallthrough": "error",
+    "no-global-assign": "error",
+    "no-implied-eval": "error",
+    "no-multi-spaces": "error",
+    "no-multi-str": "error",
+    "no-new-func": "error",
+    "no-new-wrappers": "error",
+    "no-new": "error",
+    "no-octal-escape": "error",
+    "no-redeclare": "error",
+    "no-self-assign": "error",
+    "no-unused-expressions": "error",
+    "no-unused-labels": "error",
+    "no-useless-concat": "error",
+    "wrap-iife": ["error", "any"],
+    "yoda": ["error", "never", { "onlyEquality": true, }],
+
+    // Strict Mode
+    "strict": ["error", "global"],
+
+    // Variables
+    "no-catch-shadow": "error",
+    "no-label-var": "error",
+    "no-shadow-restricted-names": "error",
+    "no-undef-init": "error",
+    "no-undef": ["error", { "typeof": true, }],
+
+    // Stylistic Issues
+    "array-bracket-spacing": ["error", "never"],
+    "block-spacing": ["error", "always"],
+    "brace-style": ["error", "1tbs", { "allowSingleLine": true, }],
+    "comma-spacing": ["error", { "before": false, "after": true, }],
+    "comma-style": ["error", "last"],
+    "eol-last": "error",
+    "func-call-spacing": ["error", "never"],
+    "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict", }],
+    "keyword-spacing": ["error", { "before": true, "after": true, }],
+    "linebreak-style": ["error", "unix"],
+    "max-len": ["error", 80],
+    "new-cap": ["error", { "newIsCap": true, "capIsNew": false, }],
+    "new-parens": "error",
+    "no-array-constructor": "error",
+    "no-multiple-empty-lines": ["error", { "max": 2, "maxEOF": 0, "maxBOF": 1, }],
+    "no-tabs": "error",
+    "no-trailing-spaces": ["error", { "skipBlankLines": false, }],
+    "no-whitespace-before-property": "error",
+    "operator-linebreak": ["error", "after", { "overrides": { ":": "ignore", } }],
+    "quotes": ["error", "single"],
+    "semi-spacing": ["error", { "before": false, "after": true, }],
+    "semi": ["error", "always"],
+    "space-before-blocks": ["error", "always"],
+    "space-before-function-paren": ["error", { "anonymous": "ignore", "named": "never", }],
+    "space-in-parens": ["error", "never"],
+    "space-infix-ops": ["error", { "int32Hint": false }],
+    "space-unary-ops": ["error", { "words": true, "nonwords": false, "overrides": { "void": false, }, }],
+  },
+}

examples/mobile-viewer/viewer.js

@@ -12,8 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-/* globals PDFJS, Promise */
+/* globals PDFJS */
 
 'use strict';
 

extensions/chromium/options/migration.js

@@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
+/* eslint strict: ["error", "function"] */
 /* globals chrome */
 
 (function() {

extensions/chromium/options/options.js

@@ -13,7 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
-/* globals chrome, Promise */
+/* globals chrome */
 
 'use strict';
 var storageAreaName = chrome.storage.sync ? 'sync' : 'local';

extensions/chromium/pdfHandler-vcros.js

@@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
+/* eslint strict: ["error", "function"] */
 /* globals chrome, getViewerURL */
 
 (function() {

extensions/chromium/telemetry.js

@@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */
+/* eslint strict: ["error", "function"] */
 /* globals chrome, crypto, Headers, Request */
 
 (function() {

extensions/firefox/.eslintrc

@@ -0,0 +1,9 @@
+{
+  "extends": [
+    ../../.eslintrc
+  ],
+
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
+}

extensions/firefox/bootstrap.js

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, dump, XPCOMUtils, PdfStreamConverter,
            APP_SHUTDOWN, PdfjsChromeUtils, PdfjsContentUtils */
 

extensions/firefox/chrome/content.js

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, XPCOMUtils, PdfjsContentUtils,
            PdfjsContentUtils, PdfStreamConverter, addMessageListener */
 

extensions/firefox/content/PdfJs-stub.jsm

@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true, maxlen:100 */
+/* eslint max-len: ["error", 100] */
 
 'use strict';
 

extensions/firefox/content/PdfJs.jsm

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, XPCOMUtils, PdfjsChromeUtils,
            PdfjsContentUtils, PdfStreamConverter */
 

extensions/firefox/content/PdfJsTelemetry-addon.jsm

@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true, maxlen:120 */
+/* eslint max-len: ["error", 120] */
 /* globals Components, Services */
 
 'use strict';

extensions/firefox/content/PdfJsTelemetry.jsm

@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true, maxlen: 100 */
+/* eslint max-len: ["error", 100] */
 /* globals Components, Services */
 
 'use strict';

extensions/firefox/content/PdfStreamConverter.jsm

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, XPCOMUtils, NetUtil, PrivateBrowsingUtils,
            dump, NetworkManager, PdfJsTelemetry, PdfjsContentUtils */
 

extensions/firefox/content/PdfjsChromeUtils.jsm

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, XPCOMUtils */
 
 'use strict';

extensions/firefox/content/PdfjsContentUtils.jsm

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint esnext:true */
 /* globals Components, Services, XPCOMUtils */
 
 'use strict';

extensions/firefox/content/pdfjschildbootstrap.js

@@ -12,7 +12,6 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-/* jshint esnext:true */
 /* globals Components, PdfjsContentUtils, PdfJs, Services */
 
 'use strict';

extensions/firefox/tools/l10n.js

@@ -1,4 +1,3 @@
-
 'use strict';
 
 // Small subset of the webL10n API by Fabien Cazenave for pdf.js extension.

external/.eslintrc

@@ -0,0 +1,10 @@
+{
+  "extends": [
+    ../.eslintrc
+  ],
+
+  "env": {
+    "node": true,
+    "shelljs": true,
+  },
+}

external/builder/builder.js

@@ -1,6 +1,3 @@
-/* jshint node:true */
-/* globals cp, ls, test */
-
 'use strict';
 
 var fs = require('fs'),
@@ -107,10 +104,8 @@ function preprocess(inFilename, outFilename, defines) {
   var line;
   var state = STATE_NONE;
   var stack = [];
-  var control =
-  /* jshint -W101 */
+  var control = // eslint-disable-next-line max-len
     /^(?:\/\/|<!--)\s*#(if|elif|else|endif|expand|include|error)\b(?:\s+(.*?)(?:-->)?$)?/;
-  /* jshint +W101 */
   var lineNumber = 0;
   var loc = function() {
     return fs.realpathSync(inFilename) + ':' + lineNumber;

external/builder/fixtures/.eslintrc

@@ -0,0 +1,11 @@
+{
+  "extends": [
+    ../../.eslintrc
+  ],
+
+  "rules": {
+    "no-empty": "off",
+    "keyword-spacing": "off",
+    "space-infix-ops": "off",
+  },
+}

external/builder/preprocessor2.js

@@ -1,5 +1,3 @@
-/* jshint node:true */
-
 'use strict';
 
 var esprima = require('esprima');
@@ -197,21 +195,25 @@ function fixComments(ctx, node) {
   }
   // Fixes double comments in the escodegen output.
   delete node.trailingComments;
-  // Removes jshint and other service comments.
+  // Removes ESLint and other service comments.
   if (node.leadingComments) {
+    var CopyrightRegExp = /\bcopyright\b/i;
+    var BlockCommentRegExp = /^\s*(globals|eslint|falls through|umdutils)\b/;
+    var LineCommentRegExp = /^\s*eslint\b/;
+
     var i = 0;
     while (i < node.leadingComments.length) {
       var type = node.leadingComments[i].type;
       var value = node.leadingComments[i].value;
 
       if (ctx.saveComments === 'copyright') {
         // Remove all comments, except Copyright notices and License headers.
-        if (!(type === 'Block' && /\bcopyright\b/i.test(value))) {
+        if (!(type === 'Block' && CopyrightRegExp.test(value))) {
           node.leadingComments.splice(i, 1);
           continue;
         }
-      } else if (type === 'Block' &&
-                 /^\s*(globals|jshint|falls through|umdutils)\b/.test(value)) {
+      } else if ((type === 'Block' && BlockCommentRegExp.test(value)) ||
+                 (type === 'Line' && LineCommentRegExp.test(value))) {
         node.leadingComments.splice(i, 1);
         continue;
       }

external/builder/test.js

@@ -1,5 +1,3 @@
-/* jshint node:true */
-/* globals cat, cd, echo, ls */
 'use strict';
 
 require('shelljs/make');

external/builder/test2.js

@@ -1,5 +1,3 @@
-/* jshint node:true */
-/* globals cat, cd, echo, ls */
 'use strict';
 
 require('shelljs/make');

external/crlfchecker/crlfchecker.js

@@ -1,6 +1,3 @@
-/* jshint node:true */
-/* globals cat, echo, exit, ls */
-
 'use strict';
 
 function checkIfCrlfIsPresent(files) {

external/crlfchecker/normtext.js

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint node:true */
 
 'use strict';
 

external/importL10n/locales.js

@@ -12,7 +12,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* jshint node:true */
 
 'use strict';