Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fxa-client] Set libfxa_client.so SONAME #174

Closed
ncalexan opened this issue Aug 9, 2018 · 2 comments
Closed

[fxa-client] Set libfxa_client.so SONAME #174

ncalexan opened this issue Aug 9, 2018 · 2 comments

Comments

@ncalexan
Copy link
Member

ncalexan commented Aug 9, 2018

Sigh. Rust doesn't set the ELF SONAME. Android's linker requires the SONAME be set. I don't know how to address this yet.
@ncalexan
Copy link
Member Author

ncalexan commented Aug 9, 2018

This will be follow up to #170 and #172, after which the FxA client library should work on Android 21+. Whew!

@ncalexan ncalexan mentioned this issue Aug 9, 2018
Merged
@thomcc
Copy link
Contributor

thomcc commented Aug 9, 2018 •
edited
Loading

I just checked and a patchelf built from https://github.com/NixOS/patchelf master can modify the soname (with --set-soname) and still be stripped afterwards (not the case with the version in homebrew). It's also a pretty simple build, since patchelf is just a single c++ file.

@thomcc thomcc mentioned this issue Aug 10, 2018
Merged
@thomcc thomcc closed this as completed in 83c4e28 Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomcc @ncalexan