Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for MinGW on Windows #5238

Closed
skhamis opened this issue Nov 16, 2022 · 0 comments · Fixed by #5243
Closed

Remove support for MinGW on Windows #5238

skhamis opened this issue Nov 16, 2022 · 0 comments · Fixed by #5243
Assignees

Comments

@skhamis
Copy link
Contributor

skhamis commented Nov 16, 2022

In an effort to simplify our NSS issues: #5210

Application services has supported building NSS via MinGW for Windows due to a when our CI started failing due to a change from rust which broke .lib linked libs

The change from static .lib for windows occurred in this PR: #3210

It looks like this is no longer an issue in the latest versions of rust:

From what I understand, it officially works for both *-windows-gnu and MSVC targets now. However, since the official NSS CI builds for MSVC targets.
Dropping support for *-windows-gnu allows us:

  • To not have to support updating *-windows-gnu via complicated phab patch for potentially no consumers.
  • Keeps us inline with the artifact binaries produced by NSS CI, which also can simplify our update process

Open to questions, concerns or issues with dropping support!

┆Issue is synchronized with this Jira Task
┆Sprint End Date: 2022-11-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant