Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MinGW support on windows #5243

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

skhamis
Copy link
Contributor

@skhamis skhamis commented Nov 17, 2022

fixes #5238

Looks like the existing failures are from a breaking change of Nimbus. This looks like it builds fine all the way to fenix just fine?

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ff-android: firefox-android-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@skhamis skhamis changed the title Remove MinGW support on windows [ff-android: firefox-android-branch-name] [fenix: fenix-branch-name] Remove MinGW support on windows [ff-android: main] [fenix: main] Nov 17, 2022
@skhamis skhamis closed this Nov 17, 2022
@skhamis skhamis reopened this Nov 17, 2022
@skhamis skhamis marked this pull request as ready for review November 17, 2022 19:34
@skhamis skhamis requested review from a team and lougeniaC64 November 18, 2022 19:01
@skhamis skhamis force-pushed the remove-mingw-support branch from 31a32e0 to bf2c0bc Compare November 18, 2022 19:07
Copy link
Contributor

@lougeniaC64 lougeniaC64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For obvious reasons, this is a bit of a rubber stamp but 🚢 😅

@skhamis skhamis changed the title Remove MinGW support on windows [ff-android: main] [fenix: main] Remove MinGW support on windows Nov 18, 2022
@skhamis skhamis force-pushed the remove-mingw-support branch from bf2c0bc to bc177ed Compare November 18, 2022 20:23
@skhamis skhamis merged commit dca2ada into mozilla:main Nov 18, 2022
@skhamis skhamis deleted the remove-mingw-support branch November 18, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for MinGW on Windows
2 participants