Add ja+ko+zh to translations feature #15962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15962 +/- ##
==========================================
+ Coverage 79.49% 79.63% +0.14%
==========================================
Files 160 160
Lines 8409 8403 -6
==========================================
+ Hits 6685 6692 +7
+ Misses 1724 1711 -13 ☔ View full report in Codecov by Sentry. |
maureenlholland
added
L10N
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel. 🤷One-line summary
CJK languages added with Fx 135 launch.
Significant changes and points to review
Launches Tue 4th Feb.
NB: The current logic strips any (regional) variants in brackets for the generated native names, so the Chinese (Simplified) is listed as "中文" instead of "中文 (简体)":
(In case zh-TW is added to the list at some point, it would get listed as "繁体中文" in comparison. That looks reasonable enough, but doublechecking from a native speaker wouldn't hurt whether that's sufficiently politically correct?)
Issue / Bugzilla link
Resolves #15954
Testing
http://localhost:8000/en/firefox/features/translate/
http://localhost:8000/nl/firefox/features/translate/