Disable Babel translation when running tests on the bots #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only should this reduce the runtime of (in particular) the Windows bot, but it will also allow us to actually test the source code as-is rather than its Babel translated version. Since the bots are running the current versions of Firefox/Chrome, testing ES6 code as-is should thus not be an issue.
timvandermeij
approved these changes
Sep 13, 2017
|
Looks good to me. Yury will also check this and merge/deploy it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only should this reduce the runtime of (in particular) the Windows bot, but it will also allow us to actually test the source code as-is rather than its Babel translated version.
Since the bots are running the current versions of Firefox/Chrome, testing ES6 code as-is should thus not be an issue.