This repository has been archived by the owner on Sep 4, 2023. It is now read-only.
Introducing end-to-end tests #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a few run examples here https://github.com/andrenatal/firefox-translations/actions, both for failures as for succeeded ones. |
abhi-agg
reviewed
Feb 16, 2022
abhi-agg
reviewed
Feb 16, 2022
Comment on lines
19
to
22
| /* | ||
| * the infobar is not triggered first time the page is loaded due some caching | ||
| * so we need to reload the tab in order to have it summoned | ||
| */ |
There was a problem hiding this comment.
the infobar is not triggered first time the page is loaded due some caching
Is this a bug that we need to resolve later?
There was a problem hiding this comment.
This happens only in the mochistest framework. We fixed something similar in the production xpi here #69 though
andrenatal
changed the title
|
I'll add tests for outbound-translations |
andrenatal
changed the title
|
Ok, this contains tests for outbound translations already. @abhi-agg r? |
abhi-agg
approved these changes
Feb 17, 2022
|
Thanks @abhi-agg |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This basically clones latest m-c, integrates the extension and the mochitest files into it, run them and report if there's failures. @abhi-agg Take a look at the mochistest to see what's being tested. I believe that's enough.
We want to test every PR and push to main, but also every night, so we could be warned of any introduced breakage from Nightly.