Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation page styling is missing #2441

Closed
2 tasks done
mozfreddyb opened this issue Nov 3, 2022 · 8 comments · Fixed by #2424
Closed
2 tasks done

Confirmation page styling is missing #2441

mozfreddyb opened this issue Nov 3, 2022 · 8 comments · Fixed by #2424
Labels
bug Something is broken!

Comments

@mozfreddyb
Copy link

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

  1. on Firefox Nightly
  2. Open a web page that defaults to open in a container
  3. navigate to said website

Actual behavior

See screenshot (unstyled error page):
image

Expected behavior

I was expecting the web page to be styled

Additional informations

I believe that aboutNetError was either refactored or the access criteria for websites have changed. I recommend incorporating the actual required stylsheets directly into the addon.

Provide a copy of Troubleshooting Information page (optional)

No response

@mozfreddyb mozfreddyb added the bug Something is broken! label Nov 3, 2022
@dannycolin dannycolin linked a pull request Nov 3, 2022 that will close this issue
@dannycolin dannycolin changed the title Unstyled container interstitial (style sheet could not be loaded aboutNetError.css) in Nightly Confirmation page styling is missing Nov 8, 2022
@maxxcrawford maxxcrawford pinned this issue Nov 15, 2022
@EmirLogas
Copy link

Same issue for me after update to Version 107.0 (64-bit).

@reedijkbart
Copy link

reedijkbart commented Nov 18, 2022

Same here, since update v107.0 (64-bit)
Edit: on windows 10

@nabeelr
Copy link

nabeelr commented Nov 18, 2022

Me as well! Same as the rest, since 107.0 on windows, 64bit.

@nabeelr
Copy link

nabeelr commented Nov 20, 2022

Any update on this? Some communication would be great.
@dannycolin @eemeli Could you provide us with an update?

@dannycolin
Copy link
Collaborator

dannycolin commented Nov 20, 2022

If all goes well, we'll push a new release this coming week the week of the 28th november.

I also want to emphasize and reassure everyone that this bug doesn't break any functionality in the addon and is purely esthetic.

@nabeelr
Copy link

nabeelr commented Nov 20, 2022

Thanks for the update, it's much appreciated. 🙏

While it's not breaking any functionality, it being such a high visibility bug with a core part of the user-interface, it makes it look like Multi-Account Containers has been abandoned, or like there is something bigger wrong.

I could see a lot of users jumping through a lot of hoops thinking something is broken on their end, trying to fix it, and not getting any resolution.

So it makes it a really bad experience for the average user who doesn't know enough to check Github, or that Github even exists, which, aside from eroding the trust in the user, it in turn makes the project look bad, and devalues all the hard work that you guys are putting in. (Hard work which is greatly appreciated by those in the know!)

As someone who loves Multi-Account Containers, as I'm sure everyone on here does, I want it to be successful and want to see wider adoption of what is a really good idea. However, since most people don't know to check Github and their knowledge of the tool ends at the user-interface, leaving aesthetic bugs like this doesn't present the hard work the team on here has put in well to the average user, even-though the average users position may be unfounded.

Anyways, thanks so much for the update, it is very much appreciated!

@mmtechslv
Copy link

Same on:
Firefox version - 107.0 (64-bit)
Fedora 36

@mozilla mozilla locked as resolved and limited conversation to collaborators Nov 25, 2022
@dannycolin
Copy link
Collaborator

dannycolin commented Dec 6, 2022

Fixed in 8.0.9. If you have auto-update enabled, you probably already have it. If not, you can always force an update. See https://support.mozilla.org/en-US/kb/how-update-add-ons for the instructions.

@dannycolin dannycolin unpinned this issue Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something is broken!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants