From 77bcc9232e61a3cfe46bfaa3412e9aa97c8d163a Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 7 Dec 2016 22:42:41 +0100 Subject: [PATCH] Remove a misplaced `false` from a condition in `fixMetadata`, in `metadata.js`, since it currently short circuits the entire condition This looks to me like a simple oversight, which has existed ever since PR 1598 all the way back in 2012. --- src/display/metadata.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/display/metadata.js b/src/display/metadata.js index fea13ebd7a7b2..d79128ffb15a9 100644 --- a/src/display/metadata.js +++ b/src/display/metadata.js @@ -37,8 +37,8 @@ var error = sharedUtil.error; var chars = ''; for (var i = 0; i < bytes.length; i += 2) { var code = bytes.charCodeAt(i) * 256 + bytes.charCodeAt(i + 1); - chars += code >= 32 && code < 127 && code !== 60 && code !== 62 && - code !== 38 && false ? String.fromCharCode(code) : + chars += (code >= 32 && code < 127 && code !== 60 && code !== 62 && + code !== 38) ? String.fromCharCode(code) : '&#x' + (0x10000 + code).toString(16).substring(1) + ';'; } return '>' + chars;