Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix webgl parameter #4919

Closed
CodingFabian opened this issue Jun 11, 2014 · 1 comment
Closed

fix webgl parameter #4919

CodingFabian opened this issue Jun 11, 2014 · 1 comment

Comments

@CodingFabian
Copy link
Contributor

I just spent 20 minutes figuring out why my webgl doesn't work.
First I tried "disableWebGL=false" because in api.js this is the name of the property and it is default initialized with true.
Then i found that this value is actually overwritten by reading from Preferences.
in preferences a value "enableWebGL" is stored. once initialized the value is negated and assigned to disableWebGL.
So I tried using "enableWebGL=true". This also did not work.
Then i figured out that the Preferences are prefilled with a value read from the URL. the value read from the url is named "webgl"

Now finally after setting "webgl=true" the preference "enableWebGL" is set to true, which on init, will set API.js PDFJS.disableWebGL, which by default is inited to true, to not the value of enableWebGL, so any check for WebGLUtils.isEnabled will no longer bail out on PDFJS.disableWebGL.

I hope you get the point :-)

@yurydelendik
Copy link
Contributor

We are trying to rely less on the hash parameters to configure the viewer: most of the parameters are moved to the preferences. In the future we probably disable these configuration parameters if user did not enable the pdfBug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants