Typo in core/jpx.js

[xiemaisi]

Lines 534--539 (https://github.com/mozilla/pdf.js/blob/master/src/core/jpx.js#L538) read

    subband.codeblockParameters = {
      codeblockWidth: xcb_,
      codeblockHeight: ycb_,
      numcodeblockwide: cbx1 - cbx0 + 1,
      numcodeblockhigh: cby1 - cby1 + 1
    };

Note that numcodeblockhigh is always initialised to 1. Presumably, it should be initialised to this instead:

      numcodeblockhigh: cby1 - cby0 + 1

[yurydelendik]

Yep, looks like a typo. Do you want any PDFs it might fix?

[xiemaisi]

I found this using a static analysis tool, so I'm not sure when (or whether) this would actually be a problem in practice.

[yurydelendik]

thanks

[yurydelendik]

I found this using a static analysis tool,

@xiemaisi very interesting, can you tell the name of the tool? :)

[xiemaisi]

It's a new static analyser we are developing at Semmle (http://semmle.com/). Proprietary, I'm afraid...