Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter too bold #6117

Closed
automatedbugreportingfacility opened this issue Jun 15, 2015 · 4 comments
Closed

Letter too bold #6117

automatedbugreportingfacility opened this issue Jun 15, 2015 · 4 comments

Comments

@automatedbugreportingfacility

This is a regression from PR #4615. The letter "F" on page 6 is unreadable.

URL: http://chrishecker.com/images/3/33/Gdmogl.pdf
1.1.209: https://i.imgur.com/IobYdDE.png
0.8.990: https://i.imgur.com/s188qBb.png

fc1e248 is the first bad commit
commit fc1e248
Author: Jonas Jenwald
Date: Fri Apr 11 20:19:39 2014 +0200

Enforce minimum line widths
@timvandermeij
Copy link
Contributor

/cc @Snuffleupagus

@Snuffleupagus
Copy link
Collaborator

In order to try avoiding drawing too thin, and thus nearly invisible, lines we use the getSinglePixelWidth method. Since this is a heavy operation, we attempt to cache the result (in cachedGetSinglePixelWidth) in order to try and speed up the rendering of PDF files with lots of drawing operations (e.g. maps).

We are currently invalidating that cache in some circumstances (currently on restore and transform), to avoid incorrect rendering. However, judging by this issue, it seems that we might simply not be invalidating the cache in every case that we actually should.

@timvandermeij
Copy link
Contributor

@automatedbugreportingfacility Thanks again for the high quality bug reports! Usually we are able to fix mentioned regressions quickly because of that.

@automatedbugreportingfacility
Copy link
Author

No problem, thank you for taking your time to fix these issues and keep pdf.js moving forward despite Mozilla pulling resources towards other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants