Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore too bold #6127

Closed
automatedbugreportingfacility opened this issue Jun 18, 2015 · 6 comments
Closed

Underscore too bold #6127

automatedbugreportingfacility opened this issue Jun 18, 2015 · 6 comments
Assignees
Labels

Comments

@automatedbugreportingfacility

This is a regression from PR #4615. The underscore for the last 2 chars in "NUMERO D’IMMATRICULATION" is too bold.

URL: http://www.ameli.fr/fileadmin/user_upload/formulaires/S3706.pdf
1.1.215: https://i.imgur.com/up8Y33j.png
0.8.990: https://i.imgur.com/UioZcLB.png

fc1e248 is the first bad commit
commit fc1e248
Author: Jonas Jenwald
Date: Fri Apr 11 20:19:39 2014 +0200

Enforce minimum line widths
@Snuffleupagus
Copy link
Collaborator

That looks "fun". Compared to the recent issue #6117, this is unfortunately not related to the fact that we fail to invalidate the getSinglePixelWidth cache. Rather the issue seems to be that, for that particular line, the actual getSinglePixelWidth method returns an "incorrect" value.

Unfortunately I've no idea how to address that :-(
Given the number of issues/bugs fixed by PR #4615, and considering how broken the rendering of some of those PDF files were before that PR, backing it out isn't really an option in my opinion.

@automatedbugreportingfacility
Copy link
Author

Agreed, I've got another regression where getSinglePixelWidth might be falling short, and it's NOT from PR #4615, but PR #4521. If you're interested in looking into that, I can file a separate issue or paste it here.

@Snuffleupagus
Copy link
Collaborator

If you're interested in looking into that, I can file a separate issue or paste it here.

Please open a new issue; if it turns out that the issues are in fact the same, we can always close one as a duplicate of the other.

@timvandermeij
Copy link
Contributor

Closing since the link is dead and it's also not available in the Web Archive.

@Snuffleupagus
Copy link
Collaborator

Closing since the link is dead and it's also not available in the Web Archive.

Since the issue still persists, I'm attaching the file here: issue6127.pdf

@Snuffleupagus
Copy link
Collaborator

@calixteman It seems that PR #12812 actually regressed this even further, can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants