Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

à character rendered where it should not be rendered #6721

Closed
timvandermeij opened this issue Dec 3, 2015 · 12 comments
Closed

à character rendered where it should not be rendered #6721

timvandermeij opened this issue Dec 3, 2015 · 12 comments
Labels
font-conversion font-type1

Comments

@timvandermeij
Copy link
Contributor

The PDF file at https://www.dropbox.com/s/ygmic028oykprkw/respond_document_print.pdf?dl=1 has random à characters rendered where they should not be.
@timvandermeij timvandermeij mentioned this issue Dec 3, 2015
Closed
@Snuffleupagus
Copy link
Collaborator

Interestingly enough, even though Adobe Reader doesn't render the à character, it's still present on copy-and-paste.

Edit: issue6721_reduced.pdf.

@mjstyle
Copy link

mjstyle commented Dec 4, 2015

Thanks guys!

@mjstyle
Copy link

mjstyle commented Dec 13, 2015

Hi guys, just wanted to check in to see if you guys were able to find a fix to this issue.

Thank you so much!

Regards,

@timvandermeij
Copy link
Contributor Author

Not yet, for these kinds of issues finding the cause of the problem is unfortunately not trivial, so this might take some time before someone has a fix.

@mjstyle
Copy link

mjstyle commented Jan 11, 2016

@timvandermeij Happy New Years everyone! Just checking in to see if anyone added a fix for this yet :)

Thanks!

Regards,

@mjstyle
Copy link

mjstyle commented Feb 21, 2016

@timvandermeij Just following up to see if there will be a planned fix soon?

Thanks!

@timvandermeij
Copy link
Contributor Author

When a fix becomes available, it will be reported here.

@brendandahl brendandahl mentioned this issue Feb 24, 2016
Merged
@mjstyle
Copy link

mjstyle commented May 30, 2016

Hi there,

Just checking in to see if this fix is out on production?

Thanks!

Regards,
Jack

@timvandermeij
Copy link
Contributor Author

The fix has been merged here, so it's most likely out for production in the current or the next Firefox release.

@mjstyle
Copy link

mjstyle commented Aug 15, 2016

Hi Tim,

I'm just following up to see if this is out on production yet?

Thanks!

Regards,
Jack

@Snuffleupagus
Copy link
Collaborator

[...] if this is out on production yet?

What does "production" actually mean in this case?
This issue was fixed in PR #7023, which is included in the 1.5.188 release of PDF.js; see https://github.com/mozilla/pdf.js/releases/tag/v1.5.188.
The PR was merged to mozilla-central in https://bugzilla.mozilla.org/show_bug.cgi?id=1253498, and the Target Milestone field says Firefox 47 (i.e. it's included in that version). As can be seen in https://wiki.mozilla.org/RapidRelease/Calendar#Past_branch_dates, the current Firefox release is version 48.

@mjstyle
Copy link

mjstyle commented Aug 31, 2016

Understood thank you!

Rob--W added a commit to Rob--W/pdf.js that referenced this issue Aug 16, 2017
@Rob--W
SVG: Don't render missing glyphs
2941dc3 
This bug is similar to the canvas bug of mozilla#6721.
I found this bug when I tried to run pdf2svg on a SVG file, and the generated
SVG could not be viewed in Chrome due to a SVG/XML parsing error:
"PCDATA invalid Char value 3"

Reduced test case:
- https://github.com/mozilla/pdf.js/files/1229507/pcdatainvalidchar.pdf
- expected: "hardware performance"
- Actual SVG source: "hardware\x03performance"
  (where "\x03" is a non-printable character, and invalid XML).

In terms of rendering, this bug is similar to mozilla#6721, where an unexpected glyph
appeared in the canvas renderer. This was fixed by mozilla#7023, which skips over
missing glyphs. This commit follows a similar logic.

The test case from mozilla#6721 can be used here too:
- https://github.com/mozilla/pdf.js/files/52205/issue6721_reduced.pdf
  expected: "Issue   6721"
  actual (before this patch): "Issue ààà6721"
@Rob--W Rob--W mentioned this issue Aug 16, 2017
Merged
Rob--W added a commit to Rob--W/pdf.js that referenced this issue Aug 16, 2017
@Rob--W
SVG: Don't render missing glyphs
f07ce2b 
This bug is similar to the canvas bug of mozilla#6721.
I found this bug when I tried to run pdf2svg on a SVG file, and the generated
SVG could not be viewed in Chrome due to a SVG/XML parsing error:
"PCDATA invalid Char value 3"

Reduced test case:
- https://github.com/mozilla/pdf.js/files/1229507/pcdatainvalidchar.pdf
- expected: "hardware performance"
- Actual SVG source: "hardware\x03performance"
  (where "\x03" is a non-printable character, and invalid XML).

In terms of rendering, this bug is similar to mozilla#6721, where an unexpected glyph
appeared in the canvas renderer. This was fixed by mozilla#7023, which skips over
missing glyphs. This commit follows a similar logic.

The test case from mozilla#6721 can be used here too:
- https://github.com/mozilla/pdf.js/files/52205/issue6721_reduced.pdf
  expected: "Issue   6721"
  actual (before this patch): "Issue ààà6721"
movsb pushed a commit to movsb/pdf.js that referenced this issue Jul 14, 2018
@Rob--W
SVG: Don't render missing glyphs
5b91967 
This bug is similar to the canvas bug of mozilla#6721.
I found this bug when I tried to run pdf2svg on a SVG file, and the generated
SVG could not be viewed in Chrome due to a SVG/XML parsing error:
"PCDATA invalid Char value 3"

Reduced test case:
- https://github.com/mozilla/pdf.js/files/1229507/pcdatainvalidchar.pdf
- expected: "hardware performance"
- Actual SVG source: "hardware\x03performance"
  (where "\x03" is a non-printable character, and invalid XML).

In terms of rendering, this bug is similar to mozilla#6721, where an unexpected glyph
appeared in the canvas renderer. This was fixed by mozilla#7023, which skips over
missing glyphs. This commit follows a similar logic.

The test case from mozilla#6721 can be used here too:
- https://github.com/mozilla/pdf.js/files/52205/issue6721_reduced.pdf
  expected: "Issue   6721"
  actual (before this patch): "Issue ààà6721"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
font-conversion font-type1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjstyle @timvandermeij @Snuffleupagus